Skip to content

Conversation

@Cipscis
Copy link
Contributor

Summary

The compatability data says Node doesn't support the signal property of EventTarget.addEventListener. However, this support was added in node v15.4.0.

Test results and supporting details

Node Changelog
Node PR merge comment

Related issues

Fixes#18883

`addEventListener` has `signal` option support since Node 15.4.0
@github-actionsgithub-actionsbot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 3, 2023
@gamliela
Copy link

Nice, thanks!

Copy link
Contributor

@queengooborgqueengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the PR number does not show up in the v14 changelog. LGTM, thank you for your PR! And welcome to BCD! 🎉

@queengooborgqueengooborg merged commit 48737d7 into mdn:mainOct 3, 2023
Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
`addEventListener` has `signal` option support since Node 15.4.0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:apiCompat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api.EventTarget.addEventListener - options.signal is supported on node.js

3 participants

@Cipscis@gamliela@queengooborg