Abstract accessor with implementation

[aozgaa]

TypeScript Version: master, commit 1418fd1

Are abstract getters/setters allowed to have an implementation?

Related: #7184

Code

abstract class A {
 private _a: string;

 abstract get a(): string {
 return this._a;
 }

 abstract set a(newName: string) {
 this._a = newName;
 }
}

Expected behavior:

Error on get and set that abstract getters/setters shouldn't have an implementation.

Actual behavior:

No error.

[aozgaa]

Thoughts, @sandersn?

[sandersn]

I can't think of a reason this would make sense.

The fix should be pretty simple, in checkGrammarAccessor just add another error check that's the inverse of the current else if (accessor.body === undefined && !(getModifierFlags(accessor) & ModifierFlags.Abstract)) ...:

[aluanhaddad]

What's the use case for this really looks strange and I think it would confuse a lot of people. I don't know any language that allows a member to be both abstract and implemented.

[sandersn]

I agree. I think it should be an error.

[aluanhaddad]

Wow I totally missread the issue I thought it was a request for this feature 🍭

[sandersn]

Nope, it's a bug, not a feature. :)