Skip to content

Broken encapsulation in mixed classes with redeclared props#13830

@tsofist

Description

@tsofist

TypeScript Version: 2.2.0-dev.20170202

#13743

Code

typeConstructor<T>=new(...args: any[])=>T;classA{publicpb: number=2;protectedptd: number=1;privatepvt: number=0;}functionmixB<TextendsConstructor<{}>>(Cls: T){returnclassextendsCls{protectedptd: number=10;//overrideprivatepvt: number=0;//hiding try};}functionmixB2<TextendsConstructor<A>>(Cls: T){returnclassextendsCls{protectedptd: number=10;//override//private pvt: number = 0; //hiding try failded: TS2415};}constAB=mixB(A),AB2=mixB2(A);functionmixC<TextendsConstructor<{}>>(Cls: T){returnclassextendsCls{protectedptd: number=100;//overrideprivatepvt: number=0;//hiding try};}constAB2C=mixC(AB2),ABC=mixC(AB);consta=newA(),ab=newAB(),abc=newABC(),ab2c=newAB2C();

Expected behavior:

a.pb.toFixed();//oka.ptd.toFixed();//error: TS2445a.pvt.toFixed();//error: TS2341ab.pb.toFixed();//okab.ptd.toFixed();//error: TS2445ab.pvt.toFixed();//error: TS2341abc.pb.toFixed();//okabc.ptd.toFixed();//error: TS2445abc.pvt.toFixed();//error: TS2341ab2c.pb.toFixed();//okab2c.ptd.toFixed();//error: TS2445ab2c.pvt.toFixed();//error: TS2341

Actual behavior:

a.pb.toFixed();//oka.ptd.toFixed();//ok error: TS2445a.pvt.toFixed();//ok error: TS2341ab.pb.toFixed();//okab.ptd.toFixed();//ok =(ab.pvt.toFixed();//ok =(abc.pb.toFixed();//okabc.ptd.toFixed();//ok =(abc.pvt.toFixed();//ok =(ab2c.pb.toFixed();//okab2c.ptd.toFixed();//ok =(ab2c.pvt.toFixed();//ok =(

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptFixedA PR has been merged for this issue

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions