Fixes error message when Type is used as a Namespace#12357
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
DanielRosenwasser commented Nov 23, 2016
Thanks for the fix! |
mylesmegyesi deleted the 12075-incorrectErrorMessageForUseOfTypeAsNamespace branch 
Merged
amcasey reviewed Nov 29, 2017
| function checkAndReportErrorForUsingTypeAsNamespace(errorLocation: Node, name: string, meaning: SymbolFlags): boolean{ | ||
| if (meaning === SymbolFlags.Namespace){ | ||
| const symbol = resolveSymbol(resolveName(errorLocation, name, SymbolFlags.Type & ~SymbolFlags.Value, /*nameNotFoundMessage*/undefined, /*nameArg*/ undefined)); |
Member
There was a problem hiding this comment.
SymbolFlags.Type & ~SymbolFlags.Value excludes classes and enums. Was that intentional? cc @DanielRosenwasser
Contributor
There was a problem hiding this comment.
I guess it should have been & ~SymbolFlags.Namespace instead
Member
There was a problem hiding this comment.
I could be missing something, but I don't think SymbolFlags.Type includes SymbolFlags.Namespace.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#12075