Update es5.d.ts#17261
Merged
Update es5.d.ts #17261
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
houfio commented Jul 18, 2017
What about |
ContributorAuthor
unional commented Jul 18, 2017
|
Contributor
ikatyang commented Jul 19, 2017
Related issue #17273 |
Contributor
rbuckton commented Aug 9, 2017
I think this looks like a good change, but would like to get some additional input. @sandersn, do you see any issues with this change? |
sandersn approved these changes Aug 9, 2017
Member
sandersn commented Aug 9, 2017
Looks good to me. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objects.keys()does not take null or undefined[x] You've signed the CLA
[x] There are new or updated unit tests validating the change