Better typings for promise.race based on conditional types#31117

RyanCavanaugh · 2019-04-25T18:48:53Z

Following the feature - Mapped tuple types #25947 - it is now possible to have better typings for Promise.race

From @dubzzz before I messed up his fork

Following the feature - Mapped tuple types microsoft#25947 - it is now possible to have better typings for Promise.race

DanielRosenwasser · 2019-04-25T20:27:14Z

This is thanks to conditional types, not mapped types.

It'd be nice to have a test of some sort (I'm sure we don't). Something simple like

leta=Promise.race([Promise.resolve(10),Promise.resolve("hello")]);

dubzzz · 2019-04-26T16:49:38Z

@DanielRosenwasser You're right. I think my first commit was really using mapped types but I changed it following reviews 🤔

RyanCavanaugh · 2019-04-30T15:54:36Z

@typescript-bot test this

typescript-bot · 2019-04-30T15:54:39Z

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 7ee4e63. You can monitor the build here. It should now contribute to this PR's status checks.

…t#31117

Fixesmicrosoft#28427

…t#31117

You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

* Better typings for Promise.resolve(), like #31117 * Add tests * Update to Awaited<T> * Fix issue with Awaited affecting jQuery, additional tests Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>

This reverts commit 040c121.

Component commits: c28ee65 Revert "Better typings for Promise.resolve(), like microsoft#31117 (microsoft#33074)" This reverts commit 040c121.

Component commits: c28ee65 Revert "Better typings for Promise.resolve(), like microsoft#31117 (microsoft#33074)" This reverts commit 040c121. Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>

Better typings for promise.race based on mapped tuple types
7ee4e63
Following the feature - Mapped tuple types microsoft#25947 - it is now possible to have better typings for Promise.race

RyanCavanaugh mentioned this pull request Apr 25, 2019
Better typings for promise.race based on mapped tuple types #27192
Closed

DanielRosenwasser changed the title ~~Better typings for promise.race based on mapped tuple types~~Better typings for promise.race based on conditional typesApr 25, 2019

RyanCavanaugh self-assigned this Apr 30, 2019

RyanCavanaugh merged commit d102ec0 into microsoft:masterApr 30, 2019

RyanCavanaugh deleted the dubzzz_port branch April 30, 2019 16:23

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
This Promise.race() overload moved to es2015.promise.d.ts inmicrosof…
b1b853c
…t#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
This Promise.race() overload moved to es2015.promise.d.ts inmicrosof…
effde01
…t#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
Better typings for Promise.all(), likemicrosoft#31117
1d79d5d
Fixesmicrosoft#28427

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
Better typings for Promise.all(), likemicrosoft#31117
83331a3

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
Better typings for Promise executor, likemicrosoft#31117
5ab6100

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
Better typings for Promise executor, likemicrosoft#31117
3476da2

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
Better typings for Promise.resolve(), likemicrosoft#31117
2c5d22e

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
Better typings for Promise.resolve(), likemicrosoft#31117
55c362c

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
Better typings for Promise.resolve(), likemicrosoft#31117
5061d7d

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
This Promise.race() overload moved to es2015.promise.d.ts inmicrosof…
5c96bc8
…t#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
Better typings for Promise.all(), likemicrosoft#31117
74c5c63

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
Better typings for Promise.resolve(), likemicrosoft#31117
d5b8656

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
Better typings for Promise executor, likemicrosoft#31117
1f6d527

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
Better typings for Promise.then(), likemicrosoft#31117
5774cd3

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
Better typings for Promise.then(), likemicrosoft#31117
75ac22d

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
Better typings for AsyncIterator/Generator, likemicrosoft#31117
31c9cfc

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
Better typings for AsyncIterator/Generator, likemicrosoft#31117
a4fc119

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
Better typings for Promise.then(), likemicrosoft#31117
fb7d414

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 29, 2019
This Promise.race() overload moved to es2015.promise.d.ts inmicrosof…
29f81fc
…t#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Aug 29, 2019
Better typings for Promise.all(), likemicrosoft#31117
73dad13

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 12, 2020
Better typings for Promise.all(), likemicrosoft#31117
7cceb79

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 12, 2020
Better typings for Promise.resolve(), likemicrosoft#31117
bb11033

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
Better typings for Promise.then(), likemicrosoft#31117
de6284c

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
e68700b
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
Better typings for Promise.all(), likemicrosoft#31117
5dc69a1

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
Better typings for Promise.resolve(), likemicrosoft#31117
7e75928

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
b93ffb5
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
c14905e
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
Better typings for Promise.all(), likemicrosoft#31117
cda17cd

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
Better typings for Promise.then(), likemicrosoft#31117
a96a831

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
Better typings for Promise.resolve(), likemicrosoft#31117
df1c5e1

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
1e8aeb0
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
Better typings for Promise.all(), likemicrosoft#31117
eccb4a4

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
6ba95ea
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
Better typings for Promise.all(), likemicrosoft#31117
d25539d

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
f8f778d
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
8381658
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
Better typings for Promise.all(), likemicrosoft#31117
4544384

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
Better typings for Promise.resolve(), likemicrosoft#31117
ac40498

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
e9a1dae
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
Move this Promise.race() overload back to es2015.iterable.d.ts
3209533
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was moved to es2015.promise.d.ts in microsoft#31117

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
Better typings for Promise.all(), likemicrosoft#31117
d40db09

jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
Better typings for Promise.then(), likemicrosoft#31117
5535587

dubzzz mentioned this pull request Jun 13, 2020
Better typings for Promise.all#39061
Closed

rbuckton pushed a commit to jablko/TypeScript that referenced this pull request Mar 18, 2022
Better typings for Promise.resolve(), likemicrosoft#31117
88254eb

sandersn added a commit that referenced this pull request Aug 8, 2022
Revert "Better typings for Promise.resolve(), like#31117(#33074)"
c28ee65
This reverts commit 040c121.

microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better typings for promise.race based on conditional types#31117

Better typings for promise.race based on conditional types #31117

Uh oh!

RyanCavanaugh commented Apr 25, 2019

Uh oh!

DanielRosenwasser commented Apr 25, 2019

Uh oh!

dubzzz commented Apr 26, 2019

Uh oh!

RyanCavanaugh commented Apr 30, 2019

Uh oh!

typescript-bot commented Apr 30, 2019•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Better typings for promise.race based on conditional types#31117

Better typings for promise.race based on conditional types #31117

Uh oh!

Conversation

RyanCavanaugh commented Apr 25, 2019

Uh oh!

DanielRosenwasser commented Apr 25, 2019

Uh oh!

dubzzz commented Apr 26, 2019

Uh oh!

RyanCavanaugh commented Apr 30, 2019

Uh oh!

typescript-bot commented Apr 30, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Apr 30, 2019•
edited
Loading