Add --git-dir and --work-tree to user tests#35362
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jablkoforce-pushed the patch-31 branch 3 times, most recently from 1036388 to 3ef366dComparejablkoforce-pushed the patch-31 branch 3 times, most recently from 01cf1d7 to e6a39b5Compare
jablkoforce-pushed the patch-31 branch 5 times, most recently from a1fc6f2 to a0a04dfComparejablkoforce-pushed the patch-31 branch 3 times, most recently from 3c2bbf7 to 95d170aCompare
Member
sandersn commented Feb 12, 2020
Your command looks like |
ContributorAuthor
jablko commented Feb 13, 2020
Yes, pretty much. Thanks! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run the user tests with
git rebase --exec, Git exportsGIT_DIRandGIT_WORK_TREEand ends up runninggit reset --hard,git clean --forceandgit pull --forceon the TypeScript project, not the test case subproject, regardless of{cwd: submoduleDir }(⌣̩̩́_⌣̩̩̀)--git-dirand--work-treeoverrideGIT_DIRandGIT_WORK_TREE, forcing it to reset the correct repository.