Skip to content

Conversation

@amcasey
Copy link
Member

When searching for a default configured project, stop at node_modules.

When searching for a default configured project, stop at `node_modules`.
@@ -0,0 +1,43 @@
namespace ts{
describe("unittests:: services:: projectService", () =>{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to go into unittests/tsserver/projects.ts instead..

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to move it, but I don't understand why - this doesn't seem to be a server test?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I see that the corresponding product code is in the server folder, but I still don't understand why the language service is in "services" but the project service is in "server".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projectService handles projects, hence is in server and not in language service folder

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are projects specific to the server?

@sandersnsandersn added the Housekeeping Housekeeping PRs label Mar 25, 2020
@sandersn
Copy link
Member

@amcasey I think this is ready to go, right?

@amcasey
Copy link
MemberAuthor

@sandersn I think I just missed the sign-off notification.

@amcaseyamcasey merged commit e1772fa into microsoft:masterMar 25, 2020
@microsoftmicrosoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

HousekeepingHousekeeping PRs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@amcasey@sandersn@sheetalkamat