Revert 'awaited' type#37610

rbuckton · 2020-03-25T22:07:37Z

The new awaited type is currently causing too many breaks to be considered stable for TS 3.9. This PR reverts the awaited type for this release while we continue to investigate the impact of the change.

Closes#37511
Closes#37512
Closes#37526
Closes#37528
Closes#37534
Closes#37551
Closes#37556
Closes#37564
Closes#37566
Closes#37567
Closes#37572
Closes#37592
Closes#37602
Closes#37603

rbuckton · 2020-03-25T22:11:15Z

@typescript-bot perf test
@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2020-03-25T22:11:18Z

Heya @rbuckton, I've started to run the perf test suite on this PR at a638aa8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2020-03-25T22:11:18Z

Heya @rbuckton, I've started to run the parallelized Definitely Typed test suite on this PR at a638aa8. You can monitor the build here.

typescript-bot · 2020-03-25T22:11:18Z

Heya @rbuckton, I've started to run the extended test suite on this PR at a638aa8. You can monitor the build here.

typescript-bot · 2020-03-25T22:11:18Z

Heya @rbuckton, I've started to run the parallelized community code test suite on this PR at a638aa8. You can monitor the build here.

sandersn

Looks reasonable to me.

typescript-bot · 2020-03-25T22:43:58Z

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

typescript-bot · 2020-03-25T23:01:15Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..37610

_Metric	_master	₃₇₆₁₀	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{327,718k (± 0.02%)}	_{326,933k (± 0.04%)}	_{-786k (- 0.24%)}	_326,512k	_327,111k
_{Parse Time}	_{1.63s (± 0.58%)}	_{1.61s (± 0.51%)}	_{-0.01s (- 0.80%)}	_1.60s	_1.64s
_{Bind Time}	_{0.89s (± 1.01%)}	_{0.88s (± 0.96%)}	_{-0.00s (- 0.56%)}	_0.86s	_0.90s
_{Check Time}	_{4.78s (± 0.48%)}	_{4.75s (± 0.51%)}	_{-0.03s (- 0.57%)}	_4.68s	_4.81s
_{Emit Time}	_{5.32s (± 0.88%)}	_{5.31s (± 0.47%)}	_{-0.02s (- 0.30%)}	_5.27s	_5.37s
_{Total Time}	_{12.61s (± 0.55%)}	_{12.55s (± 0.35%)}	_{-0.06s (- 0.50%)}	_12.44s	_12.62s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{327,135k (± 0.02%)}	_{327,078k (± 0.02%)}	_{-57k (- 0.02%)}	_326,936k	_327,296k
_{Parse Time}	_{1.25s (± 0.61%)}	_{1.25s (± 0.29%)}	_{-0.00s (- 0.08%)}	_1.25s	_1.26s
_{Bind Time}	_{0.77s (± 0.58%)}	_{0.77s (± 0.44%)}	_{+0.00s (+ 0.13%)}	_0.77s	_0.78s
_{Check Time}	_{4.73s (± 0.26%)}	_{4.74s (± 0.62%)}	_{+0.01s (+ 0.11%)}	_4.67s	_4.80s
_{Emit Time}	_{2.92s (± 0.71%)}	_{2.91s (± 0.50%)}	_{-0.01s (- 0.48%)}	_2.87s	_2.94s
_{Total Time}	_{9.69s (± 0.22%)}	_{9.68s (± 0.36%)}	_{-0.01s (- 0.10%)}	_9.61s	_9.75s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{291,963k (± 0.02%)}	_{291,993k (± 0.03%)}	_{+30k (+ 0.01%)}	_291,878k	_292,172k
_{Parse Time}	_{0.95s (± 0.47%)}	_{0.95s (± 0.38%)}	_{-0.01s (- 0.63%)}	_0.94s	_0.95s
_{Bind Time}	_{0.75s (± 0.80%)}	_{0.74s (± 0.66%)}	_{-0.00s (- 0.27%)}	_0.73s	_0.75s
_{Check Time}	_{4.26s (± 0.58%)}	_{4.26s (± 0.29%)}	_{+0.00s (+ 0.05%)}	_4.24s	_4.28s
_{Emit Time}	_{3.06s (± 0.36%)}	_{3.05s (± 0.80%)}	_{-0.01s (- 0.46%)}	_3.00s	_3.09s
_{Total Time}	_{9.02s (± 0.28%)}	_{9.00s (± 0.27%)}	_{-0.01s (- 0.16%)}	_8.94s	_9.05s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{452,881k (± 0.01%)}	_{452,579k (± 0.01%)}	_{-302k (- 0.07%)}	_452,488k	_452,666k
_{Parse Time}	_{1.77s (± 0.31%)}	_{1.77s (± 0.37%)}	_{0.00s ( 0.00%)}	_1.76s	_1.79s
_{Bind Time}	_{0.68s (± 0.77%)}	_{0.68s (± 0.59%)}	_{0.00s ( 0.00%)}	_0.67s	_0.69s
_{Check Time}	_{13.66s (± 0.69%)}	_{13.60s (± 0.56%)}	_{-0.06s (- 0.43%)}	_13.42s	_13.76s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.11s (± 0.59%)}	_{16.06s (± 0.46%)}	_{-0.06s (- 0.37%)}	_15.88s	_16.21s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{303,414k (± 0.03%)}	_{302,662k (± 0.08%)}	_{-752k (- 0.25%)}	_301,675k	_302,946k
_{Parse Time}	_{1.58s (± 0.56%)}	_{1.57s (± 0.41%)}	_{-0.01s (- 0.32%)}	_1.56s	_1.59s
_{Bind Time}	_{0.87s (± 0.83%)}	_{0.87s (± 0.68%)}	_{+0.00s (+ 0.23%)}	_0.86s	_0.89s
_{Check Time}	_{4.64s (± 0.45%)}	_{4.64s (± 1.05%)}	_{+0.00s (+ 0.02%)}	_4.58s	_4.83s
_{Emit Time}	_{5.47s (± 0.46%)}	_{5.48s (± 1.00%)}	_{+0.01s (+ 0.13%)}	_5.39s	_5.67s
_{Total Time}	_{12.56s (± 0.26%)}	_{12.57s (± 0.78%)}	_{+0.00s (+ 0.04%)}	_12.46s	_12.94s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{307,099k (± 0.02%)}	_{307,015k (± 0.02%)}	_{-83k (- 0.03%)}	_306,795k	_307,128k
_{Parse Time}	_{1.20s (± 0.62%)}	_{1.20s (± 0.49%)}	_{+0.00s (+ 0.33%)}	_1.19s	_1.22s
_{Bind Time}	_{0.75s (± 1.02%)}	_{0.74s (± 0.92%)}	_{-0.01s (- 1.21%)}	_0.73s	_0.76s
_{Check Time}	_{4.56s (± 0.22%)}	_{4.55s (± 0.45%)}	_{-0.00s (- 0.04%)}	_4.53s	_4.61s
_{Emit Time}	_{2.96s (± 0.49%)}	_{2.95s (± 0.47%)}	_{-0.01s (- 0.30%)}	_2.92s	_2.97s
_{Total Time}	_{9.46s (± 0.20%)}	_{9.45s (± 0.28%)}	_{-0.01s (- 0.13%)}	_9.38s	_9.49s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{274,292k (± 0.03%)}	_{274,307k (± 0.02%)}	_{+15k (+ 0.01%)}	_274,166k	_274,404k
_{Parse Time}	_{0.93s (± 0.51%)}	_{0.93s (± 0.48%)}	_{-0.00s (- 0.11%)}	_0.92s	_0.94s
_{Bind Time}	_{0.70s (± 1.23%)}	_{0.70s (± 1.18%)}	_{+0.00s (+ 0.43%)}	_0.69s	_0.73s
_{Check Time}	_{4.17s (± 0.43%)}	_{4.19s (± 0.48%)}	_{+0.02s (+ 0.41%)}	_4.14s	_4.23s
_{Emit Time}	_{3.10s (± 1.10%)}	_{3.09s (± 0.99%)}	_{-0.01s (- 0.45%)}	_3.02s	_3.16s
_{Total Time}	_{8.91s (± 0.43%)}	_{8.91s (± 0.47%)}	_{+0.00s (+ 0.01%)}	_8.84s	_9.01s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{430,291k (± 0.01%)}	_{429,928k (± 0.05%)}	_{-364k (- 0.08%)}	_429,033k	_430,241k
_{Parse Time}	_{1.75s (± 0.40%)}	_{1.75s (± 0.33%)}	_{+0.00s (+ 0.06%)}	_1.74s	_1.76s
_{Bind Time}	_{0.63s (± 0.75%)}	_{0.63s (± 1.02%)}	_{+0.00s (+ 0.32%)}	_0.62s	_0.65s
_{Check Time}	_{12.15s (± 0.55%)}	_{12.10s (± 0.29%)}	_{-0.05s (- 0.41%)}	_12.04s	_12.20s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.53s (± 0.42%)}	_{14.48s (± 0.26%)}	_{-0.05s (- 0.35%)}	_14.40s	_14.58s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{322,812k (± 0.02%)}	_{322,061k (± 0.01%)}	_{-752k (- 0.23%)}	_321,957k	_322,166k
_{Parse Time}	_{2.12s (± 0.21%)}	_{2.10s (± 0.33%)}	_{-0.01s (- 0.61%)}	_2.09s	_2.12s
_{Bind Time}	_{0.91s (± 0.37%)}	_{0.92s (± 0.79%)}	_{+0.00s (+ 0.55%)}	_0.91s	_0.94s
_{Check Time}	_{5.48s (± 1.18%)}	_{5.43s (± 1.06%)}	_{-0.05s (- 0.91%)}	_5.26s	_5.51s
_{Emit Time}	_{6.24s (± 1.95%)}	_{6.26s (± 1.28%)}	_{+0.02s (+ 0.40%)}	_6.14s	_6.54s
_{Total Time}	_{14.75s (± 0.72%)}	_{14.71s (± 0.33%)}	_{-0.03s (- 0.22%)}	_14.59s	_14.85s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{325,482k (± 0.01%)}	_{325,498k (± 0.01%)}	_{+16k (+ 0.00%)}	_325,424k	_325,593k
_{Parse Time}	_{1.55s (± 0.44%)}	_{1.54s (± 0.43%)}	_{-0.00s (- 0.19%)}	_1.53s	_1.56s
_{Bind Time}	_{0.89s (± 0.38%)}	_{0.89s (± 0.58%)}	_{-0.00s (- 0.45%)}	_0.88s	_0.90s
_{Check Time}	_{5.35s (± 0.65%)}	_{5.37s (± 0.43%)}	_{+0.01s (+ 0.21%)}	_5.32s	_5.42s
_{Emit Time}	_{3.51s (± 0.72%)}	_{3.50s (± 0.36%)}	_{-0.01s (- 0.31%)}	_3.48s	_3.53s
_{Total Time}	_{11.30s (± 0.47%)}	_{11.30s (± 0.24%)}	_{-0.00s (- 0.03%)}	_11.25s	_11.35s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{291,358k (± 0.02%)}	_{291,365k (± 0.01%)}	_{+7k (+ 0.00%)}	_291,275k	_291,419k
_{Parse Time}	_{1.25s (± 0.47%)}	_{1.26s (± 0.47%)}	_{+0.00s (+ 0.16%)}	_1.24s	_1.27s
_{Bind Time}	_{0.75s (± 0.64%)}	_{0.74s (± 0.63%)}	_{-0.01s (- 0.94%)}	_0.73s	_0.75s
_{Check Time}	_{4.88s (± 1.27%)}	_{4.86s (± 1.90%)}	_{-0.02s (- 0.47%)}	_4.74s	_5.12s
_{Emit Time}	_{3.31s (± 2.11%)}	_{3.29s (± 1.51%)}	_{-0.02s (- 0.48%)}	_3.15s	_3.36s
_{Total Time}	_{10.19s (± 0.39%)}	_{10.15s (± 0.51%)}	_{-0.04s (- 0.39%)}	_10.05s	_10.31s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{455,455k (± 0.01%)}	_{455,141k (± 0.01%)}	_{-313k (- 0.07%)}	_455,022k	_455,220k
_{Parse Time}	_{2.11s (± 0.72%)}	_{2.10s (± 0.53%)}	_{-0.00s (- 0.14%)}	_2.08s	_2.13s
_{Bind Time}	_{0.81s (± 1.03%)}	_{0.81s (± 1.19%)}	_{+0.00s (+ 0.37%)}	_0.79s	_0.83s
_{Check Time}	_{17.64s (± 0.62%)}	_{17.65s (± 0.38%)}	_{+0.01s (+ 0.09%)}	_17.52s	_17.83s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{20.55s (± 0.59%)}	_{20.56s (± 0.36%)}	_{+0.02s (+ 0.08%)}	_20.43s	_20.77s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{185,749k (± 0.02%)}	_{185,365k (± 0.03%)}	_{-385k (- 0.21%)}	_185,244k	_185,519k
_{Parse Time}	_{2.05s (± 0.35%)}	_{2.06s (± 0.84%)}	_{+0.01s (+ 0.24%)}	_2.03s	_2.11s
_{Bind Time}	_{1.07s (± 0.52%)}	_{1.07s (± 0.35%)}	_{-0.00s (- 0.28%)}	_1.06s	_1.07s
_{Check Time}	_{4.99s (± 0.59%)}	_{4.99s (± 0.32%)}	_{-0.00s (- 0.02%)}	_4.95s	_5.03s
_{Emit Time}	_{6.06s (± 0.44%)}	_{6.03s (± 0.68%)}	_{-0.03s (- 0.49%)}	_5.97s	_6.14s
_{Total Time}	_{14.17s (± 0.35%)}	_{14.15s (± 0.45%)}	_{-0.02s (- 0.17%)}	_14.04s	_14.31s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{185,276k (± 0.02%)}	_{185,251k (± 0.02%)}	_{-24k (- 0.01%)}	_185,185k	_185,330k
_{Parse Time}	_{1.59s (± 0.76%)}	_{1.61s (± 1.19%)}	_{+0.01s (+ 0.75%)}	_1.57s	_1.66s
_{Bind Time}	_{0.76s (± 0.58%)}	_{0.77s (± 1.22%)}	_{+0.01s (+ 1.05%)}	_0.75s	_0.79s
_{Check Time}	_{5.39s (± 0.44%)}	_{5.41s (± 0.68%)}	_{+0.02s (+ 0.32%)}	_5.34s	_5.49s
_{Emit Time}	_{2.86s (± 0.83%)}	_{2.89s (± 1.28%)}	_{+0.03s (+ 1.05%)}	_2.81s	_3.00s
_{Total Time}	_{10.61s (± 0.42%)}	_{10.68s (± 0.76%)}	_{+0.07s (+ 0.69%)}	_10.53s	_10.91s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{166,797k (± 0.02%)}	_{166,763k (± 0.02%)}	_{-34k (- 0.02%)}	_166,687k	_166,877k
_{Parse Time}	_{1.29s (± 0.60%)}	_{1.28s (± 0.38%)}	_{-0.01s (- 0.39%)}	_1.27s	_1.29s
_{Bind Time}	_{0.71s (± 0.70%)}	_{0.71s (± 0.81%)}	_{-0.01s (- 0.70%)}	_0.70s	_0.72s
_{Check Time}	_{4.61s (± 0.64%)}	_{4.60s (± 0.54%)}	_{-0.01s (- 0.20%)}	_4.55s	_4.66s
_{Emit Time}	_{2.99s (± 1.06%)}	_{2.96s (± 1.08%)}	_{-0.03s (- 1.14%)}	_2.89s	_3.01s
_{Total Time}	_{9.60s (± 0.44%)}	_{9.55s (± 0.44%)}	_{-0.05s (- 0.54%)}	_9.46s	_9.63s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{257,642k (± 0.02%)}	_{257,423k (± 0.01%)}	_{-219k (- 0.08%)}	_257,369k	_257,517k
_{Parse Time}	_{2.19s (± 0.70%)}	_{2.18s (± 0.57%)}	_{-0.01s (- 0.32%)}	_2.14s	_2.19s
_{Bind Time}	_{0.68s (± 1.37%)}	_{0.68s (± 1.20%)}	_{+0.00s (+ 0.29%)}	_0.66s	_0.70s
_{Check Time}	_{16.26s (± 0.87%)}	_{16.19s (± 0.44%)}	_{-0.07s (- 0.44%)}	_16.10s	_16.41s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{19.12s (± 0.75%)}	_{19.05s (± 0.40%)}	_{-0.07s (- 0.39%)}	_18.96s	_19.30s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₃₇₆₁₀	₁₀
_Baseline	_master	₁₀

rbuckton · 2020-03-25T23:16:46Z

I found a few more stragglers, will update shortly.

rbuckton · 2020-03-25T23:30:29Z

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2020-03-25T23:30:33Z

Heya @rbuckton, I've started to run the extended test suite on this PR at 28946c3. You can monitor the build here.

typescript-bot · 2020-03-25T23:30:33Z

Heya @rbuckton, I've started to run the parallelized community code test suite on this PR at 28946c3. You can monitor the build here.

typescript-bot · 2020-03-25T23:30:33Z

Heya @rbuckton, I've started to run the parallelized Definitely Typed test suite on this PR at 28946c3. You can monitor the build here.

rbuckton · 2020-03-26T00:51:37Z

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2020-03-26T00:51:42Z

Heya @rbuckton, I've started to run the parallelized Definitely Typed test suite on this PR at 5017cb8. You can monitor the build here.

typescript-bot · 2020-03-26T00:51:42Z

Heya @rbuckton, I've started to run the parallelized community code test suite on this PR at 5017cb8. You can monitor the build here.

typescript-bot · 2020-03-26T00:51:42Z

Heya @rbuckton, I've started to run the extended test suite on this PR at 5017cb8. You can monitor the build here.

rbuckton · 2020-03-26T01:39:36Z

RWC changes look good
user/docker changes look good except for some errors in vscode that look to be due to Fix emit for optional chain with non-null assertion #36539, not this PR.
DT changes look good

rbuckton · 2020-03-26T01:40:16Z

@typescript-bot cherry-pick this to release-3.9

typescript-bot · 2020-03-26T01:40:22Z

Heya @rbuckton, I've started to run the task to cherry-pick this into release-3.9 on this PR at 5017cb8. You can monitor the build here.

typescript-bot · 2020-03-26T01:44:17Z

Hey @rbuckton, I've opened #37614 for you.

Component commits: 5017cb8 Revert 'awaited' type

Component commits: 5017cb8 Revert 'awaited' type Co-authored-by: Ron Buckton <rbuckton@microsoft.com>

Luxcium · 2020-03-27T14:42:01Z

oops... I was relying on this solution because I have a Promise<MaybeList<Promise<ISymbolSearchResult[]>>>
where MaybeList is an array abstraction so I am using promise.all to remove the inner Promise I don't know what to do now to avoid using as unknown as MaybeList<ISymbolSearchResult[]> inside of my async function (which should be returning the Promise<MaybeList<ISymbolSearchResult[]>> instead of the Promise<MaybeList<Promise<ISymbolSearchResult[]>>>)

typescript-bot assigned rbuckton Mar 25, 2020

typescript-bot added the Author: Team label Mar 25, 2020

rbuckton requested review from DanielRosenwasser, RyanCavanaugh and sandersn March 25, 2020 22:10

This was referenced Mar 25, 2020
Fix inference of type arguments when source is 'awaited' #37540
Closed
Weaken the definition of PromiseLike to allow 'T | awaited T' #37570
Closed

sandersn approved these changes Mar 25, 2020
View reviewed changes

typescript-bot mentioned this pull request Mar 25, 2020
🤖 User test baselines have changed for revertAwaitedType typescript-bot/TypeScript#11
Open

rbuckton force-pushed the revertAwaitedType branch from a638aa8 to 28946c3Compare March 25, 2020 23:29

This was referenced Mar 25, 2020
[3.5.1] Iterable is missing in lib.es2015.promise.d.ts #31722
Closed
fix(lib/es2015): Move Promise.race(Iterable) to es2015.iterable.d.ts#36435
Closed

Revert 'awaited' type
5017cb8

rbuckton force-pushed the revertAwaitedType branch from 28946c3 to 5017cb8Compare March 26, 2020 00:37

rbuckton merged commit 4fc4c4e into masterMar 26, 2020

typescript-bot mentioned this pull request Mar 26, 2020
🤖 Pick PR #37610 (Revert 'awaited' type) into release-3.9 #37614
Merged

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 26, 2020
Cherry-pick PRmicrosoft#37610into release-3.9
a0ef598
Component commits: 5017cb8 Revert 'awaited' type

rbuckton added a commit that referenced this pull request Mar 26, 2020
Cherry-pick PR#37610into release-3.9 (#37614)
859f4c1
Component commits: 5017cb8 Revert 'awaited' type Co-authored-by: Ron Buckton <rbuckton@microsoft.com>

amcasey mentioned this pull request Apr 1, 2020
Null-check call result rather than function itself eclipse-theia/theia#7468
Merged
1 task

rbuckton mentioned this pull request Dec 16, 2020
Cannot find name 'Iterable' when including ES2015.Promise #37680
Closed

jakebailey deleted the revertAwaitedType branch November 7, 2022 17:36

weswigham mentioned this pull request Mar 11, 2024
[react] Enable Awaited<ReactNode> in experimental release channels DefinitelyTyped/DefinitelyTyped#68918
Merged

microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025

Revert 'awaited' type#37610

Revert 'awaited' type #37610

Uh oh!

Conversation

rbuckton commented Mar 25, 2020

Uh oh!

rbuckton commented Mar 25, 2020

Uh oh!

typescript-bot commented Mar 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Mar 25, 2020

Uh oh!

typescript-bot commented Mar 25, 2020

Uh oh!

rbuckton commented Mar 25, 2020

Uh oh!

rbuckton commented Mar 25, 2020

Uh oh!

typescript-bot commented Mar 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rbuckton commented Mar 26, 2020

Uh oh!

typescript-bot commented Mar 26, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 26, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 26, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rbuckton commented Mar 26, 2020

Uh oh!

rbuckton commented Mar 26, 2020

Uh oh!

typescript-bot commented Mar 26, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 26, 2020

Uh oh!

Luxcium commented Mar 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Mar 25, 2020•
edited
Loading

typescript-bot commented Mar 25, 2020•
edited
Loading

typescript-bot commented Mar 25, 2020•
edited
Loading

typescript-bot commented Mar 25, 2020•
edited
Loading

typescript-bot commented Mar 25, 2020•
edited
Loading

typescript-bot commented Mar 25, 2020•
edited
Loading

typescript-bot commented Mar 25, 2020•
edited
Loading

typescript-bot commented Mar 26, 2020•
edited
Loading

typescript-bot commented Mar 26, 2020•
edited
Loading

typescript-bot commented Mar 26, 2020•
edited
Loading

typescript-bot commented Mar 26, 2020•
edited
Loading