Skip to content

Add isDeeplyNestedType logic to getResolvedBaseConstraint#40971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahejlsberg merged 5 commits into from
Oct 7, 2020
Merged

Add isDeeplyNestedType logic to getResolvedBaseConstraint #40971

ahejlsberg merged 5 commits into from
Oct 7, 2020

Conversation

@ahejlsberg
Copy link
Member

@ahejlsbergahejlsberg commented Oct 6, 2020

Fixes#40970.

@typescript-bottypescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Oct 6, 2020
@ahejlsberg
Copy link
MemberAuthor

ahejlsberg commented Oct 6, 2020

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 6, 2020•
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 56dc16e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 6, 2020•
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 56dc16e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 6, 2020•
edited
Loading

Heya @ahejlsberg, I've started to run the perf test suite on this PR at 56dc16e. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 6, 2020•
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 56dc16e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 6, 2020

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..40971

Metricmaster40971DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used349,757k (± 0.02%)349,793k (± 0.02%)+36k (+ 0.01%)349,659k350,054k
Parse Time2.01s (± 0.80%)2.00s (± 0.65%)-0.00s (- 0.25%)1.98s2.04s
Bind Time0.82s (± 1.07%)0.82s (± 0.68%)-0.00s (- 0.12%)0.81s0.84s
Check Time4.94s (± 0.54%)4.96s (± 0.81%)+0.02s (+ 0.38%)4.89s5.07s
Emit Time5.19s (± 0.41%)5.19s (± 0.45%)+0.00s (+ 0.00%)5.13s5.24s
Total Time12.96s (± 0.34%)12.97s (± 0.32%)+0.01s (+ 0.08%)12.91s13.09s
Monaco - node (v10.16.3, x64)
Memory used354,351k (± 0.02%)354,373k (± 0.03%)+22k (+ 0.01%)354,150k354,646k
Parse Time1.57s (± 0.57%)1.56s (± 0.45%)-0.01s (- 0.32%)1.55s1.57s
Bind Time0.71s (± 0.56%)0.72s (± 0.81%)+0.01s (+ 0.84%)0.71s0.73s
Check Time5.07s (± 0.54%)5.08s (± 0.43%)+0.01s (+ 0.24%)5.05s5.15s
Emit Time2.76s (± 0.93%)2.76s (± 1.11%)-0.00s (- 0.14%)2.70s2.83s
Total Time10.11s (± 0.37%)10.12s (± 0.38%)+0.01s (+ 0.08%)10.03s10.19s
TFS - node (v10.16.3, x64)
Memory used307,640k (± 0.04%)307,606k (± 0.02%)-35k (- 0.01%)307,490k307,746k
Parse Time1.22s (± 0.76%)1.22s (± 0.39%)-0.00s (- 0.16%)1.21s1.23s
Bind Time0.66s (± 1.37%)0.67s (± 1.30%)+0.01s (+ 1.06%)0.65s0.68s
Check Time4.57s (± 0.94%)4.56s (± 0.76%)-0.01s (- 0.13%)4.48s4.65s
Emit Time2.90s (± 1.72%)2.86s (± 1.56%)-0.04s (- 1.45%)2.75s2.94s
Total Time9.35s (± 0.59%)9.30s (± 0.43%)-0.04s (- 0.47%)9.22s9.38s
material-ui - node (v10.16.3, x64)
Memory used489,125k (± 0.02%)488,998k (± 0.01%)-127k (- 0.03%)488,923k489,077k
Parse Time1.99s (± 0.54%)1.98s (± 0.43%)-0.01s (- 0.50%)1.97s2.00s
Bind Time0.65s (± 0.90%)0.65s (± 0.56%)-0.00s (- 0.15%)0.64s0.65s
Check Time13.42s (± 0.51%)13.49s (± 0.65%)+0.06s (+ 0.48%)13.32s13.75s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time16.06s (± 0.45%)16.12s (± 0.55%)+0.05s (+ 0.34%)15.95s16.36s
Angular - node (v12.1.0, x64)
Memory used326,934k (± 0.02%)326,857k (± 0.10%)-77k (- 0.02%)325,478k327,124k
Parse Time2.00s (± 0.53%)1.99s (± 0.53%)-0.01s (- 0.50%)1.97s2.02s
Bind Time0.81s (± 1.12%)0.80s (± 0.72%)-0.01s (- 0.74%)0.79s0.81s
Check Time4.83s (± 0.40%)4.90s (± 1.25%)+0.06s (+ 1.28%)4.81s5.09s
Emit Time5.39s (± 0.84%)5.38s (± 0.76%)-0.02s (- 0.37%)5.31s5.48s
Total Time13.04s (± 0.52%)13.06s (± 0.52%)+0.03s (+ 0.19%)12.95s13.23s
Monaco - node (v12.1.0, x64)
Memory used336,578k (± 0.02%)336,586k (± 0.02%)+9k (+ 0.00%)336,464k336,746k
Parse Time1.54s (± 0.72%)1.54s (± 0.49%)+0.01s (+ 0.52%)1.52s1.56s
Bind Time0.69s (± 0.58%)0.69s (± 0.80%)+0.00s (+ 0.44%)0.68s0.71s
Check Time4.88s (± 0.50%)4.88s (± 0.45%)-0.00s (- 0.08%)4.84s4.93s
Emit Time2.82s (± 0.91%)2.80s (± 0.56%)-0.02s (- 0.74%)2.76s2.84s
Total Time9.93s (± 0.39%)9.92s (± 0.32%)-0.01s (- 0.13%)9.85s9.99s
TFS - node (v12.1.0, x64)
Memory used291,933k (± 0.03%)291,876k (± 0.02%)-58k (- 0.02%)291,795k292,041k
Parse Time1.23s (± 0.49%)1.23s (± 0.76%)+0.00s (+ 0.24%)1.21s1.25s
Bind Time0.65s (± 1.38%)0.64s (± 1.01%)-0.01s (- 1.24%)0.62s0.65s
Check Time4.47s (± 0.30%)4.49s (± 0.46%)+0.03s (+ 0.63%)4.46s4.55s
Emit Time2.92s (± 0.99%)2.95s (± 0.90%)+0.03s (+ 1.13%)2.90s3.01s
Total Time9.26s (± 0.36%)9.31s (± 0.30%)+0.06s (+ 0.60%)9.27s9.37s
material-ui - node (v12.1.0, x64)
Memory used467,034k (± 0.05%)466,910k (± 0.07%)-125k (- 0.03%)465,961k467,237k
Parse Time2.01s (± 0.37%)2.01s (± 0.58%)-0.00s (- 0.10%)1.99s2.04s
Bind Time0.64s (± 1.05%)0.63s (± 0.94%)-0.00s (- 0.47%)0.62s0.65s
Check Time12.05s (± 0.94%)12.03s (± 0.85%)-0.01s (- 0.12%)11.86s12.30s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time14.70s (± 0.81%)14.68s (± 0.67%)-0.02s (- 0.13%)14.51s14.92s
Angular - node (v8.9.0, x64)
Memory used346,442k (± 0.01%)346,399k (± 0.03%)-43k (- 0.01%)346,148k346,585k
Parse Time2.54s (± 0.51%)2.55s (± 0.68%)+0.00s (+ 0.16%)2.52s2.61s
Bind Time0.85s (± 0.43%)0.86s (± 0.61%)+0.00s (+ 0.59%)0.85s0.87s
Check Time5.56s (± 0.52%)5.58s (± 0.65%)+0.03s (+ 0.47%)5.53s5.66s
Emit Time6.15s (± 1.07%)6.11s (± 1.54%)-0.04s (- 0.65%)5.92s6.30s
Total Time15.11s (± 0.55%)15.10s (± 0.69%)-0.01s (- 0.05%)14.92s15.39s
Monaco - node (v8.9.0, x64)
Memory used355,704k (± 0.02%)355,730k (± 0.01%)+26k (+ 0.01%)355,663k355,805k
Parse Time1.89s (± 0.77%)1.88s (± 0.28%)-0.01s (- 0.27%)1.87s1.89s
Bind Time0.89s (± 0.45%)0.89s (± 0.38%)-0.00s (- 0.45%)0.88s0.89s
Check Time5.62s (± 0.37%)5.63s (± 0.30%)+0.00s (+ 0.04%)5.60s5.67s
Emit Time3.29s (± 1.17%)3.22s (± 0.56%)-0.07s (- 2.04%)3.19s3.27s
Total Time11.69s (± 0.28%)11.61s (± 0.25%)-0.08s (- 0.67%)11.56s11.68s
TFS - node (v8.9.0, x64)
Memory used309,391k (± 0.02%)309,396k (± 0.01%)+4k (+ 0.00%)309,333k309,478k
Parse Time1.55s (± 0.64%)1.56s (± 0.54%)+0.01s (+ 0.39%)1.54s1.57s
Bind Time0.68s (± 0.73%)0.67s (± 0.55%)-0.00s (- 0.15%)0.67s0.68s
Check Time5.31s (± 0.58%)5.30s (± 0.47%)-0.01s (- 0.13%)5.25s5.35s
Emit Time2.94s (± 0.34%)2.94s (± 0.56%)-0.00s (- 0.03%)2.89s2.98s
Total Time10.48s (± 0.34%)10.47s (± 0.27%)-0.01s (- 0.11%)10.41s10.54s
material-ui - node (v8.9.0, x64)
Memory used493,431k (± 0.01%)493,459k (± 0.01%)+28k (+ 0.01%)493,326k493,542k
Parse Time2.40s (± 0.46%)2.40s (± 0.30%)-0.00s (- 0.04%)2.39s2.42s
Bind Time0.81s (± 1.02%)0.81s (± 0.58%)-0.00s (- 0.12%)0.80s0.82s
Check Time17.95s (± 0.69%)18.09s (± 0.72%)+0.14s (+ 0.76%)17.73s18.40s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time21.17s (± 0.56%)21.31s (± 0.61%)+0.13s (+ 0.63%)20.95s21.62s
Angular - node (v8.9.0, x86)
Memory used198,690k (± 0.01%)198,731k (± 0.02%)+41k (+ 0.02%)198,598k198,807k
Parse Time2.48s (± 1.02%)2.47s (± 0.75%)-0.01s (- 0.28%)2.43s2.51s
Bind Time1.00s (± 1.00%)1.01s (± 0.59%)+0.01s (+ 1.10%)1.00s1.03s
Check Time5.05s (± 0.56%)5.07s (± 0.72%)+0.02s (+ 0.44%)5.02s5.17s
Emit Time5.89s (± 0.83%)5.96s (± 0.64%)+0.08s (+ 1.34%)5.86s6.05s
Total Time14.42s (± 0.58%)14.52s (± 0.49%)+0.10s (+ 0.72%)14.32s14.67s
Monaco - node (v8.9.0, x86)
Memory used201,493k (± 0.01%)201,505k (± 0.02%)+12k (+ 0.01%)201,427k201,602k
Parse Time1.94s (± 1.05%)1.94s (± 1.02%)-0.00s (- 0.21%)1.91s1.99s
Bind Time0.71s (± 0.47%)0.71s (± 0.78%)-0.00s (- 0.28%)0.69s0.72s
Check Time5.47s (± 0.38%)5.52s (± 1.39%)+0.06s (+ 1.04%)5.44s5.72s
Emit Time3.06s (± 0.59%)2.99s (± 3.88%)-0.06s (- 2.03%)2.68s3.11s
Total Time11.18s (± 0.25%)11.17s (± 0.62%)-0.01s (- 0.11%)11.01s11.32s
TFS - node (v8.9.0, x86)
Memory used176,867k (± 0.03%)176,870k (± 0.02%)+3k (+ 0.00%)176,782k176,958k
Parse Time1.60s (± 1.10%)1.59s (± 0.61%)-0.02s (- 1.00%)1.57s1.61s
Bind Time0.66s (± 2.04%)0.64s (± 0.77%)-0.01s (- 1.53%)0.64s0.66s
Check Time4.82s (± 0.58%)4.82s (± 0.77%)-0.00s (- 0.04%)4.78s4.94s
Emit Time2.80s (± 0.66%)2.83s (± 0.71%)+0.02s (+ 0.78%)2.80s2.88s
Total Time9.88s (± 0.51%)9.88s (± 0.49%)-0.00s (- 0.05%)9.80s10.01s
material-ui - node (v8.9.0, x86)
Memory used277,878k (± 0.02%)277,858k (± 0.01%)-20k (- 0.01%)277,782k277,968k
Parse Time2.46s (± 0.43%)2.47s (± 0.96%)+0.01s (+ 0.45%)2.42s2.51s
Bind Time0.69s (± 1.35%)0.71s (± 3.50%)+0.02s (+ 2.91%)0.67s0.79s
Check Time16.45s (± 0.73%)16.43s (± 0.53%)-0.02s (- 0.15%)16.23s16.69s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time19.60s (± 0.63%)19.60s (± 0.55%)+0.01s (+ 0.03%)19.39s19.93s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory3 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
BenchmarkNameIterations
Current4097110
Baselinemaster10

@typescript-bottypescript-bot mentioned this pull request Oct 6, 2020
Open
@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 6, 2020

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg
Copy link
MemberAuthor

ahejlsberg commented Oct 6, 2020

Tests all look clean. No performance impact.

DanielRosenwasser
DanielRosenwasser approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@DanielRosenwasserDanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, get a second pair of eyes just to be safe.

@ahejlsbergahejlsberg merged commit f342209 into masterOct 7, 2020
@ahejlsbergahejlsberg deleted the fix40970 branch October 7, 2020 12:50
@weswighamweswigham mentioned this pull request Dec 4, 2020
Merged
This was referenced Dec 14, 2020
Closed
Merged
@microsoftmicrosoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasserDanielRosenwasserDanielRosenwasser approved these changes

@weswighamweswighamweswigham approved these changes

@RyanCavanaughRyanCavanaughAwaiting requested review from RyanCavanaugh

Assignees

@ahejlsbergahejlsberg

Labels

For Milestone BugPRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Excessive depth exploring template literal type constraints

5 participants

@ahejlsberg@typescript-bot@DanielRosenwasser@weswigham