Skip to content

fix(52440): typeof ... === "undefined" check on mapped object member doesn't narrow correctly, for only some purposes#52456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RyanCavanaugh merged 1 commit into from
Jan 30, 2023
Merged

fix(52440): typeof ... === "undefined" check on mapped object member doesn't narrow correctly, for only some purposes #52456

RyanCavanaugh merged 1 commit into from
Jan 30, 2023

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuka-tarasyuk commented Jan 27, 2023

Fixes#52440

@typescript-bottypescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 27, 2023
@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Jan 27, 2023

This looks right but I don't want to get surprised

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023•
edited
Loading

Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023•
edited
Loading

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at e09645c. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023•
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023•
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023•
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023•
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at e09645c. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023•
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/52456/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/52456/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023

Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/52456/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/52456/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52456
Metricmain52456DeltaBestWorst
Angular - node (v18.10.0, x64)
Memory used359,843k (± 0.02%)359,777k (± 0.01%)-66k (- 0.02%)359,736k359,878k
Parse Time3.96s (± 0.65%)3.93s (± 0.73%)-0.03s (- 0.84%)3.89s3.97s
Bind Time1.17s (± 0.54%)1.17s (± 0.35%)+0.00s (+ 0.14%)1.17s1.18s
Check Time8.63s (± 0.32%)8.62s (± 0.56%)-0.00s (- 0.06%)8.56s8.70s
Emit Time7.59s (± 0.39%)7.61s (± 0.51%)+0.02s (+ 0.20%)7.54s7.66s
Total Time21.35s (± 0.19%)21.33s (± 0.42%)-0.02s (- 0.09%)21.24s21.49s
Compiler-Unions - node (v18.10.0, x64)
Memory used192,532k (± 0.07%)192,413k (± 0.07%)-119k (- 0.06%)192,210k192,532k
Parse Time1.64s (± 2.00%)1.63s (± 1.72%)-0.01s (- 0.30%)1.59s1.66s
Bind Time0.79s (± 0.52%)0.79s (± 0.65%)+0.00s (+ 0.21%)0.79s0.80s
Check Time9.61s (± 0.24%)9.67s (± 0.50%)+0.06s (+ 0.59%)9.63s9.76s
Emit Time2.88s (± 5.77%)2.92s (± 5.11%)+0.04s (+ 1.51%)2.80s3.11s
Total Time14.92s (± 1.16%)15.02s (± 0.87%)+0.10s (+ 0.66%)14.90s15.19s
Monaco - node (v18.10.0, x64)
Memory used343,964k (± 0.01%)343,981k (± 0.01%)+17k (+ 0.00%)343,952k344,010k
Parse Time2.95s (± 0.93%)2.95s (± 0.94%)-0.00s (- 0.06%)2.90s2.97s
Bind Time1.03s (± 1.29%)1.03s (± 0.96%)-0.00s (- 0.32%)1.02s1.04s
Check Time7.06s (± 0.53%)7.07s (± 0.43%)+0.01s (+ 0.19%)7.04s7.12s
Emit Time4.34s (± 0.83%)4.33s (± 0.24%)-0.01s (- 0.23%)4.32s4.35s
Total Time15.39s (± 0.37%)15.39s (± 0.30%)+0.00s (+ 0.01%)15.32s15.44s
TFS - node (v18.10.0, x64)
Memory used300,380k (± 0.01%)300,371k (± 0.01%)-9k (- 0.00%)300,339k300,416k
Parse Time2.25s (± 1.16%)2.24s (± 1.56%)-0.01s (- 0.52%)2.21s2.29s
Bind Time1.17s (± 1.08%)1.17s (± 0.64%)-0.00s (- 0.14%)1.16s1.18s
Check Time6.50s (± 0.50%)6.53s (± 0.95%)+0.03s (+ 0.41%)6.46s6.62s
Emit Time3.91s (± 0.44%)3.93s (± 0.62%)+0.02s (+ 0.47%)3.91s3.97s
Total Time13.84s (± 0.50%)13.86s (± 0.52%)+0.03s (+ 0.20%)13.74s13.94s
material-ui - node (v18.10.0, x64)
Memory used476,737k (± 0.00%)476,796k (± 0.02%)+59k (+ 0.01%)476,711k476,920k
Parse Time3.57s (± 0.23%)3.56s (± 0.79%)-0.01s (- 0.19%)3.51s3.59s
Bind Time0.96s (± 0.54%)0.97s (± 0.42%)+0.01s (+ 0.52%)0.96s0.97s
Check Time17.07s (± 0.66%)17.04s (± 0.55%)-0.03s (- 0.20%)16.91s17.17s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time21.60s (± 0.51%)21.56s (± 0.47%)-0.04s (- 0.16%)21.43s21.68s
xstate - node (v18.10.0, x64)
Memory used548,679k (± 0.02%)548,602k (± 0.01%)-77k (- 0.01%)548,526k548,694k
Parse Time4.55s (± 0.38%)4.56s (± 0.27%)+0.00s (+ 0.07%)4.54s4.57s
Bind Time1.72s (± 1.04%)1.71s (± 1.25%)-0.01s (- 0.48%)1.69s1.74s
Check Time2.72s (± 0.99%)2.72s (± 0.91%)+0.00s (+ 0.06%)2.69s2.75s
Emit Time0.09s (± 5.95%)0.08s (± 6.19%)🟩-0.00s (- 3.85%)0.08s0.09s
Total Time9.08s (± 0.27%)9.08s (± 0.54%)+0.00s (+ 0.04%)9.05s9.16s
Angular - node (v16.17.1, x64)
Memory used359,209k (± 0.00%)359,219k (± 0.00%)+10k (+ 0.00%)359,192k359,242k
Parse Time4.17s (± 0.13%)4.17s (± 0.12%)-0.00s (- 0.04%)4.17s4.18s
Bind Time1.22s (± 0.68%)1.23s (± 0.99%)+0.00s (+ 0.14%)1.21s1.24s
Check Time9.40s (± 0.42%)9.41s (± 0.44%)+0.01s (+ 0.09%)9.36s9.47s
Emit Time8.05s (± 0.29%)8.04s (± 0.33%)-0.01s (- 0.10%)8.01s8.08s
Total Time22.85s (± 0.17%)22.85s (± 0.25%)-0.00s (- 0.01%)22.77s22.91s
Compiler-Unions - node (v16.17.1, x64)
Memory used194,270k (± 0.03%)194,240k (± 0.03%)-30k (- 0.02%)194,172k194,294k
Parse Time1.81s (± 0.67%)1.81s (± 0.49%)+0.00s (+ 0.18%)1.80s1.82s
Bind Time0.84s (± 0.61%)0.84s (± 1.06%)-0.00s (- 0.40%)0.83s0.85s
Check Time10.38s (± 0.41%)10.38s (± 0.74%)0.00s ( 0.00%)10.32s10.53s
Emit Time3.06s (± 0.67%)3.06s (± 0.93%)-0.00s (- 0.11%)3.02s3.10s
Total Time16.09s (± 0.35%)16.09s (± 0.42%)-0.00s (- 0.01%)16.02s16.21s
Monaco - node (v16.17.1, x64)
Memory used343,260k (± 0.01%)343,257k (± 0.02%)-3k (- 0.00%)343,212k343,347k
Parse Time3.18s (± 1.39%)3.18s (± 1.25%)0.00s ( 0.00%)3.12s3.23s
Bind Time1.11s (± 0.68%)1.11s (± 0.46%)+0.00s (+ 0.45%)1.11s1.12s
Check Time7.71s (± 0.25%)7.74s (± 0.28%)+0.02s (+ 0.30%)7.71s7.76s
Emit Time4.52s (± 0.41%)4.52s (± 0.60%)0.00s ( 0.00%)4.49s4.56s
Total Time16.52s (± 0.22%)16.55s (± 0.41%)+0.03s (+ 0.16%)16.49s16.65s
TFS - node (v16.17.1, x64)
Memory used299,763k (± 0.01%)299,768k (± 0.01%)+5k (+ 0.00%)299,734k299,784k
Parse Time2.47s (± 1.44%)2.46s (± 0.88%)-0.00s (- 0.14%)2.43s2.49s
Bind Time1.25s (± 0.60%)1.25s (± 0.41%)+0.00s (+ 0.13%)1.25s1.26s
Check Time7.17s (± 0.39%)7.18s (± 0.70%)+0.02s (+ 0.23%)7.13s7.27s
Emit Time4.21s (± 0.61%)4.21s (± 0.58%)-0.01s (- 0.16%)4.18s4.24s
Total Time15.10s (± 0.37%)15.10s (± 0.28%)-0.00s (- 0.00%)15.04s15.15s
material-ui - node (v16.17.1, x64)
Memory used476,072k (± 0.02%)476,052k (± 0.01%)-20k (- 0.00%)475,994k476,142k
Parse Time3.71s (± 0.28%)3.72s (± 0.11%)+0.01s (+ 0.22%)3.72s3.73s
Bind Time1.01s (± 0.51%)1.02s (± 0.00%)+0.01s (+ 0.66%)1.02s1.02s
Check Time18.18s (± 0.82%)18.06s (± 0.10%)-0.12s (- 0.63%)18.04s18.08s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time22.91s (± 0.66%)22.80s (± 0.07%)-0.11s (- 0.46%)22.78s22.82s
xstate - node (v16.17.1, x64)
Memory used546,315k (± 0.02%)546,384k (± 0.02%)+69k (+ 0.01%)546,246k546,499k
Parse Time4.77s (± 0.59%)4.75s (± 0.59%)-0.02s (- 0.31%)4.71s4.79s
Bind Time1.82s (± 3.93%)1.84s (± 0.77%)+0.02s (+ 1.38%)1.82s1.86s
Check Time3.01s (± 2.87%)2.97s (± 0.82%)-0.04s (- 1.28%)2.94s3.01s
Emit Time0.09s (± 4.45%)0.09s (± 5.53%)+0.00s (+ 1.82%)0.09s0.10s
Total Time9.68s (± 0.47%)9.65s (± 0.34%)-0.03s (- 0.31%)9.60s9.70s
Angular - node (v14.15.1, x64)
Memory used352,844k (± 0.01%)352,843k (± 0.01%)-1k (- 0.00%)352,819k352,875k
Parse Time4.21s (± 0.41%)4.25s (± 0.48%)+0.04s (+ 0.95%)4.23s4.28s
Bind Time1.28s (± 0.32%)1.28s (± 0.40%)+0.00s (+ 0.39%)1.28s1.29s
Check Time9.75s (± 0.22%)9.67s (± 0.56%)-0.08s (- 0.77%)9.61s9.76s
Emit Time8.37s (± 0.58%)8.40s (± 0.38%)+0.03s (+ 0.32%)8.37s8.44s
Total Time23.61s (± 0.27%)23.61s (± 0.32%)-0.00s (- 0.01%)23.50s23.71s
Compiler-Unions - node (v14.15.1, x64)
Memory used189,683k (± 0.70%)189,202k (± 0.07%)-481k (- 0.25%)189,063k189,395k
Parse Time1.84s (± 0.66%)1.86s (± 0.74%)+0.01s (+ 0.72%)1.84s1.88s
Bind Time0.86s (± 0.60%)0.87s (± 0.97%)+0.01s (+ 0.97%)0.86s0.88s
Check Time10.42s (± 0.70%)10.39s (± 0.75%)-0.03s (- 0.29%)10.30s10.51s
Emit Time3.42s (± 3.85%)3.39s (± 4.98%)-0.02s (- 0.68%)3.15s3.52s
Total Time16.54s (± 0.72%)16.51s (± 0.95%)-0.03s (- 0.20%)16.26s16.70s
Monaco - node (v14.15.1, x64)
Memory used338,030k (± 0.00%)338,032k (± 0.00%)+2k (+ 0.00%)338,014k338,055k
Parse Time3.22s (± 0.66%)3.23s (± 0.74%)+0.01s (+ 0.41%)3.19s3.25s
Bind Time1.11s (± 0.68%)1.11s (± 0.57%)+0.00s (+ 0.15%)1.10s1.12s
Check Time8.05s (± 0.54%)8.06s (± 0.67%)+0.01s (+ 0.17%)7.97s8.12s
Emit Time4.74s (± 0.70%)4.76s (± 0.36%)+0.02s (+ 0.49%)4.73s4.78s
Total Time17.11s (± 0.38%)17.17s (± 0.48%)+0.06s (+ 0.33%)17.05s17.24s
TFS - node (v14.15.1, x64)
Memory used294,587k (± 0.01%)294,604k (± 0.00%)+17k (+ 0.01%)294,586k294,621k
Parse Time2.76s (± 0.44%)2.75s (± 0.23%)-0.01s (- 0.18%)2.74s2.76s
Bind Time1.10s (± 0.89%)1.11s (± 0.76%)+0.00s (+ 0.30%)1.09s1.11s
Check Time7.49s (± 0.25%)7.51s (± 0.45%)+0.03s (+ 0.36%)7.48s7.55s
Emit Time4.61s (± 0.63%)4.61s (± 0.65%)+0.00s (+ 0.11%)4.57s4.65s
Total Time15.95s (± 0.34%)15.98s (± 0.36%)+0.02s (+ 0.15%)15.90s16.07s
material-ui - node (v14.15.1, x64)
Memory used471,565k (± 0.00%)471,563k (± 0.00%)-3k (- 0.00%)471,547k471,583k
Parse Time3.94s (± 0.67%)3.94s (± 0.57%)+0.01s (+ 0.17%)3.92s3.97s
Bind Time1.04s (± 1.16%)1.05s (± 0.49%)+0.00s (+ 0.32%)1.04s1.05s
Check Time18.94s (± 0.11%)19.07s (± 0.34%)+0.13s (+ 0.66%)18.95s19.13s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time23.92s (± 0.13%)24.06s (± 0.30%)+0.13s (+ 0.56%)23.93s24.12s
xstate - node (v14.15.1, x64)
Memory used534,481k (± 0.00%)534,468k (± 0.01%)-13k (- 0.00%)534,438k534,507k
Parse Time5.12s (± 0.69%)5.16s (± 0.58%)+0.05s (+ 0.88%)5.11s5.19s
Bind Time1.71s (± 0.44%)1.71s (± 0.78%)+0.00s (+ 0.20%)1.69s1.73s
Check Time3.10s (± 1.09%)3.09s (± 0.67%)-0.01s (- 0.38%)3.07s3.13s
Emit Time0.10s (± 0.00%)0.10s (± 0.00%)0.00s ( 0.00%)0.10s0.10s
Total Time10.03s (± 0.67%)10.07s (± 0.47%)+0.04s (+ 0.35%)9.99s10.12s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current524566
Baselinemain6

TSServer

Comparison Report - main..52456
Metricmain52456DeltaBestWorst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,515ms (± 1.42%)2,536ms (± 1.23%)+21ms (+ 0.82%)2,479ms2,570ms
Req 2 - geterr5,504ms (± 0.41%)5,497ms (± 0.77%)-7ms (- 0.12%)5,449ms5,548ms
Req 3 - references363ms (± 0.73%)365ms (± 0.73%)+2ms (+ 0.55%)361ms369ms
Req 4 - navto285ms (± 0.29%)284ms (± 0.48%)-0ms (- 0.12%)283ms287ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo68ms (± 5.11%)66ms (± 1.24%)🟩-3ms (- 3.67%)64ms66ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,713ms (± 0.98%)2,713ms (± 0.63%)0ms ( 0.00%)2,696ms2,736ms
Req 2 - geterr4,055ms (± 0.42%)4,055ms (± 0.46%)+1ms (+ 0.02%)4,032ms4,076ms
Req 3 - references367ms (± 0.54%)368ms (± 0.97%)+1ms (+ 0.36%)365ms375ms
Req 4 - navto297ms (± 0.72%)301ms (± 0.75%)+4ms (+ 1.24%)298ms304ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo80ms (± 7.93%)82ms (± 0.50%)+2ms (+ 2.51%)81ms82ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,489ms (± 0.84%)3,493ms (± 0.62%)+3ms (+ 0.10%)3,472ms3,532ms
Req 2 - geterr1,415ms (± 1.01%)1,414ms (± 0.63%)-1ms (- 0.06%)1,404ms1,425ms
Req 3 - references104ms (± 1.99%)104ms (± 1.66%)+0ms (+ 0.16%)102ms106ms
Req 4 - navto357ms (± 1.84%)356ms (± 0.35%)-1ms (- 0.23%)354ms357ms
Req 5 - completionInfo count3,175 (± 0.00%)3,175 (± 0.00%)0 ( 0.00%)3,1753,175
Req 5 - completionInfo471ms (± 0.94%)468ms (± 1.50%)-3ms (- 0.53%)459ms476ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,783ms (± 0.25%)2,772ms (± 0.60%)-12ms (- 0.43%)2,748ms2,795ms
Req 2 - geterr5,881ms (± 0.49%)5,875ms (± 0.34%)-6ms (- 0.09%)5,852ms5,901ms
Req 3 - references376ms (± 1.63%)377ms (± 1.23%)+1ms (+ 0.13%)370ms384ms
Req 4 - navto277ms (± 0.66%)278ms (± 0.81%)+1ms (+ 0.18%)274ms280ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo74ms (± 4.19%)77ms (±10.22%)+3ms (+ 4.31%)70ms91ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,932ms (± 0.78%)2,932ms (± 0.84%)-0ms (- 0.01%)2,903ms2,972ms
Req 2 - geterr4,393ms (± 0.28%)4,393ms (± 0.31%)-1ms (- 0.02%)4,378ms4,411ms
Req 3 - references377ms (± 0.70%)379ms (± 0.97%)+3ms (+ 0.66%)374ms383ms
Req 4 - navto288ms (± 0.26%)288ms (± 0.87%)-0ms (- 0.06%)283ms290ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo72ms (± 1.14%)73ms (± 1.12%)+1ms (+ 1.40%)72ms74ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,631ms (± 0.44%)3,632ms (± 0.23%)+2ms (+ 0.04%)3,619ms3,640ms
Req 2 - geterr1,566ms (± 0.65%)1,556ms (± 0.85%)-10ms (- 0.61%)1,542ms1,580ms
Req 3 - references111ms (± 1.44%)112ms (± 1.10%)+0ms (+ 0.30%)110ms113ms
Req 4 - navto344ms (± 1.11%)342ms (± 1.43%)-2ms (- 0.68%)338ms348ms
Req 5 - completionInfo count3,175 (± 0.00%)3,175 (± 0.00%)0 ( 0.00%)3,1753,175
Req 5 - completionInfo484ms (± 1.46%)478ms (± 0.69%)-6ms (- 1.31%)473ms481ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,905ms (± 0.17%)2,910ms (± 0.52%)+5ms (+ 0.16%)2,886ms2,926ms
Req 2 - geterr6,249ms (± 0.73%)6,284ms (± 0.68%)+35ms (+ 0.56%)6,210ms6,341ms
Req 3 - references389ms (± 0.60%)392ms (± 0.88%)+3ms (+ 0.73%)386ms396ms
Req 4 - navto284ms (± 1.19%)282ms (± 1.83%)-2ms (- 0.53%)278ms291ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo81ms (± 8.67%)87ms (± 8.88%)+5ms (+ 6.35%)73ms92ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,091ms (± 0.79%)3,086ms (± 1.02%)-6ms (- 0.18%)3,054ms3,139ms
Req 2 - geterr4,687ms (± 0.13%)4,705ms (± 0.37%)+17ms (+ 0.37%)4,678ms4,730ms
Req 3 - references405ms (± 0.60%)405ms (± 0.97%)+1ms (+ 0.16%)403ms413ms
Req 4 - navto291ms (± 1.06%)291ms (± 0.85%)-1ms (- 0.17%)288ms295ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo83ms (± 4.41%)81ms (± 0.64%)-2ms (- 2.62%)80ms81ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,961ms (± 0.77%)3,982ms (± 0.75%)+21ms (+ 0.52%)3,947ms4,018ms
Req 2 - geterr1,503ms (± 0.91%)1,535ms (± 1.79%)+33ms (+ 2.17%)1,509ms1,565ms
Req 3 - references134ms (± 2.26%)132ms (± 3.49%)-2ms (- 1.50%)126ms137ms
Req 4 - navto375ms (± 0.89%)374ms (± 0.36%)-0ms (- 0.09%)373ms377ms
Req 5 - completionInfo count3,175 (± 0.00%)3,175 (± 0.00%)0 ( 0.00%)3,1753,175
Req 5 - completionInfo510ms (± 1.99%)502ms (± 2.71%)-7ms (- 1.44%)483ms515ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
BenchmarkNameIterations
Current524566
Baselinemain6

Startup

Comparison Report - main..52456
Metricmain52456DeltaBestWorst
tsc-startup - node (v16.17.1, x64)
Execution time142.20ms (± 0.18%)142.96ms (± 0.35%)+0.75ms (+ 0.53%)141.90ms146.92ms
tsserver-startup - node (v16.17.1, x64)
Execution time225.82ms (± 0.19%)228.82ms (± 0.41%)+3.00ms (+ 1.33%)224.84ms233.65ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time228.34ms (± 0.23%)231.57ms (± 0.33%)+3.23ms (+ 1.42%)227.52ms237.49ms
typescript-startup - node (v16.17.1, x64)
Execution time209.31ms (± 0.17%)212.20ms (± 0.36%)+2.89ms (+ 1.38%)208.91ms221.01ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current524566
Baselinemain6

Developer Information:

Download Benchmark

@RyanCavanaughRyanCavanaugh merged commit 3c0a3e5 into microsoft:mainJan 30, 2023
@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Jan 30, 2023

Thanks!

@AndaristAndarist mentioned this pull request Feb 1, 2023
Merged
@microsoftmicrosoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

For Backlog BugPRs that fix a backlog bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

typeof ... === "undefined" check on mapped object member doesn't narrow correctly, for only some purposes

3 participants

@a-tarasyuk@RyanCavanaugh@typescript-bot