Enable @typescript-eslint/ban-types#55133
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #54693.
All of the things it catches are harmless, realistically, though I agree that
as Functionwas the wrong cast as that'd let us accidentallynewit or something.I definitely disagree with the default of banning
{}; that's a very useful type (especially post #49119, a number I have memorized at this point). Annoyingly, violating the rule that bans{}orObjectsays to useNonNullable<unknown>which is exactly{}.The fact that
Symbolis mistaken as the globalSymbolI believe is a bug in ts-eslint,though I don't think it's reported so I'll do that shortly.typescript-eslint/typescript-eslint#7306Disabling those two leaves the rule to only ban the uppercase primitive wrapper types (good) and
Object(probably good), so it seems like this rule is fine to keep enabled.