consistently check expressions with >, >=, <, <= for unconstrained types in strictNullChecks#59352

iisaduan · 2024-07-19T03:31:51Z

fixes#50603, which bisected to #49119

Previously: unconstrained type parameters were inconsistently checked in comparisons, as shown below (5.5.3 playground):

functionf<T>(a: T,b: T){returna>b; \\ okay}functiong<Textends{}|undefined|null>(a: T,b: T){returna>b; \\ error!! \\ 'a'ispossibly'null'or'undefined'.ts(18049) \\ 'b'ispossibly'null'or'undefined'.ts(18049)}

Now with this PR:

functionf1<T>(a: T,b: T): boolean{returna>b;~!!!errorTS18046: 'a'isoftype'unknown'.~!!!errorTS18046: 'b'isoftype'unknown'.}functionf2<Textends{}|undefined|null>(a: T,b: T): boolean{returna>b;~!!!errorTS18049: 'a'ispossibly'null'or'undefined'.~!!!errorTS18049: 'b'ispossibly'null'or'undefined'.}

This PR does not affect the checking of unconstrained types in other locations.

iisaduan · 2024-07-19T05:19:43Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-07-19T05:19:46Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-19T05:21:39Z

Hey @iisaduan, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{"devDependencies":{"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162857/artifacts?artifactName=tgz&fileId=44CAF8D1A815E861B024867349A1BA4D64F7A3FF9ADC7FD310912E8F233464F902&fileName=/typescript-5.6.0-insiders.20240719.tgz" } }

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2024-07-19T05:41:59Z

Hey @iisaduan, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-19T05:44:23Z

@iisaduan Here are the results of running the user tests with tsc comparing main and refs/pull/59352/merge:

Everything looks good!

typescript-bot · 2024-07-19T05:56:14Z

@iisaduan
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,883k (± 0.75%)}	_{192,382k (± 0.10%)}	_~	_192,239k	_192,624k	_{p=0.689 n=6}
_{Parse Time}	_{1.29s (± 0.90%)}	_{1.30s (± 0.80%)}	_~	_1.29s	_1.32s	_{p=0.085 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.54s (± 0.45%)}	_{9.50s (± 0.48%)}	_~	_9.43s	_9.55s	_{p=0.170 n=6}
_{Emit Time}	_{2.76s (± 0.55%)}	_{2.75s (± 0.68%)}	_~	_2.73s	_2.77s	_{p=0.933 n=6}
_{Total Time}	_{14.30s (± 0.35%)}	_{14.27s (± 0.35%)}	_~	_14.21s	_14.35s	_{p=0.336 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₁₅	_{🔻+10 (+200.00%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_944,250	_944,250	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,076	_407,076	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,709k (± 0.00%)}	_{1,218,714k (± 0.00%)}	_~	_1,218,661k	_1,218,766k	_{p=0.810 n=6}
_{Parse Time}	_{6.72s (± 0.64%)}	_{6.69s (± 0.55%)}	_~	_6.63s	_6.73s	_{p=0.227 n=6}
_{Bind Time}	_{1.87s (± 0.83%)}	_{1.87s (± 0.79%)}	_~	_1.85s	_1.88s	_{p=0.784 n=6}
_{Check Time}	_{31.01s (± 0.17%)}	_{31.01s (± 0.38%)}	_~	_30.91s	_31.23s	_{p=0.574 n=6}
_{Emit Time}	_{15.02s (± 0.71%)}	_{14.96s (± 0.17%)}	_~	_14.93s	_15.01s	_{p=0.288 n=6}
_{Total Time}	_{54.61s (± 0.17%)}	_{54.53s (± 0.21%)}	_~	_54.40s	_54.71s	_{p=0.230 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₁₆	_{🔻+16 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_2,276,156	_2,276,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_948,845	_948,825	_{-20 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,207,610k (± 0.00%)}	_{2,207,609k (± 0.00%)}	_~	_2,207,577k	_2,207,642k	_{p=1.000 n=6}
_{Parse Time}	_{6.61s (± 0.18%)}	_{6.60s (± 0.25%)}	_~	_6.58s	_6.62s	_{p=0.103 n=6}
_{Bind Time}	_{2.33s (± 0.22%)}	_{2.33s (± 0.35%)}	_~	_2.32s	_2.34s	_{p=0.929 n=6}
_{Check Time}	_{73.08s (± 0.37%)}	_{73.12s (± 0.29%)}	_~	_72.75s	_73.32s	_{p=0.872 n=6}
_{Emit Time}	_0.14s	_{0.14s (± 6.38%)}	_~	_0.13s	_0.15s	_{p=1.000 n=6}
_{Total Time}	_{82.17s (± 0.33%)}	_{82.19s (± 0.26%)}	_~	_81.82s	_82.37s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,332	_1,227,334	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,851	_261,852	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,341,654k (± 0.02%)}	_{2,341,474k (± 0.02%)}	_~	_2,340,763k	_2,342,012k	_{p=0.471 n=6}
_{Parse Time}	_{5.10s (± 0.55%)}	_{5.12s (± 0.85%)}	_~	_5.06s	_5.17s	_{p=0.471 n=6}
_{Bind Time}	_{1.90s (± 0.43%)}	_{1.91s (± 1.03%)}	_~	_1.88s	_1.93s	_{p=0.744 n=6}
_{Check Time}	_{34.39s (± 0.38%)}	_{34.57s (± 0.11%)}	_{+0.18s (+ 0.51%)}	_34.53s	_34.62s	_{p=0.013 n=6}
_{Emit Time}	_{3.29s (± 2.35%)}	_{3.32s (± 2.44%)}	_~	_3.22s	_3.40s	_{p=0.470 n=6}
_{Total Time}	_{44.69s (± 0.15%)}	_{44.91s (± 0.11%)}	_{+0.23s (+ 0.51%)}	_44.85s	_44.98s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,332	_1,227,334	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,851	_261,852	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,475,459k (± 5.82%)}	_{2,534,670k (±11.36%)}	_~	_2,416,382k	_3,123,003k	_{p=0.378 n=6}
_{Parse Time}	_{7.85s (± 0.77%)}	_{7.88s (± 0.74%)}	_~	_7.82s	_7.98s	_{p=0.688 n=6}
_{Bind Time}	_{2.50s (± 0.73%)}	_{2.50s (± 1.29%)}	_~	_2.46s	_2.54s	_{p=1.000 n=6}
_{Check Time}	_{50.57s (± 0.65%)}	_{50.75s (± 0.67%)}	_~	_50.50s	_51.42s	_{p=0.936 n=6}
_{Emit Time}	_{4.87s (± 2.12%)}	_{4.87s (± 1.08%)}	_~	_4.80s	_4.93s	_{p=0.936 n=6}
_{Total Time}	_{65.81s (± 0.58%)}	_{66.01s (± 0.63%)}	_~	_65.69s	_66.83s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,516	_258,518	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,901	_104,902	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,933k (± 0.02%)}	_{427,880k (± 0.03%)}	_~	_427,778k	_428,078k	_{p=0.298 n=6}
_{Parse Time}	_{4.15s (± 0.30%)}	_{4.15s (± 0.33%)}	_~	_4.13s	_4.17s	_{p=0.547 n=6}
_{Bind Time}	_{1.63s (± 1.44%)}	_{1.62s (± 1.20%)}	_~	_1.60s	_1.65s	_{p=0.405 n=6}
_{Check Time}	_{22.15s (± 0.44%)}	_{22.23s (± 0.40%)}	_~	_22.10s	_22.38s	_{p=0.170 n=6}
_{Emit Time}	_{2.01s (± 1.03%)}	_{2.01s (± 0.83%)}	_~	_1.99s	_2.03s	_{p=1.000 n=6}
_{Total Time}	_{29.94s (± 0.23%)}	_{30.01s (± 0.28%)}	_~	_29.88s	_30.14s	_{p=0.149 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,623k (± 0.02%)}	_{369,740k (± 0.03%)}	_~	_369,571k	_369,882k	_{p=0.128 n=6}
_{Parse Time}	_{3.45s (± 0.59%)}	_{3.45s (± 0.90%)}	_~	_3.42s	_3.50s	_{p=0.808 n=6}
_{Bind Time}	_{1.93s (± 0.78%)}	_{1.94s (± 0.65%)}	_~	_1.92s	_1.95s	_{p=0.134 n=6}
_{Check Time}	_{19.33s (± 0.38%)}	_{19.36s (± 0.23%)}	_~	_19.30s	_19.41s	_{p=0.336 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.71s (± 0.25%)}	_{24.75s (± 0.31%)}	_~	_24.64s	_24.84s	_{p=0.298 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,973,126	_2,973,126	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,021,075	_1,021,075	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,097,512k (± 0.00%)}	_{3,097,551k (± 0.00%)}	_~	_3,097,468k	_3,097,652k	_{p=0.575 n=6}
_{Parse Time}	_{13.93s (± 0.27%)}	_{13.89s (± 0.33%)}	_~	_13.83s	_13.95s	_{p=0.127 n=6}
_{Bind Time}	_{4.44s (± 2.10%)}	_{4.39s (± 2.95%)}	_~	_4.27s	_4.53s	_{p=1.000 n=6}
_{Check Time}	_{79.00s (± 0.23%)}	_{79.20s (± 0.30%)}	_~	_78.92s	_79.49s	_{p=0.261 n=6}
_{Emit Time}	_{20.31s (± 0.42%)}	_{20.35s (± 0.85%)}	_~	_20.15s	_20.65s	_{p=0.630 n=6}
_{Total Time}	_{117.68s (± 0.21%)}	_{117.83s (± 0.29%)}	_~	_117.25s	_118.28s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,370	_267,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,862	_108,862	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,941k (± 0.02%)}	_{411,946k (± 0.02%)}	_~	_411,871k	_412,054k	_{p=0.936 n=6}
_{Parse Time}	_{4.74s (± 0.68%)}	_{4.76s (± 0.39%)}	_~	_4.72s	_4.77s	_{p=0.357 n=6}
_{Bind Time}	_{2.09s (± 0.78%)}	_{2.08s (± 0.39%)}	_~	_2.08s	_2.10s	_{p=0.227 n=6}
_{Check Time}	_{20.82s (± 0.24%)}	_{20.89s (± 0.40%)}	_~	_20.79s	_21.00s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.65s (± 0.24%)}	_{27.73s (± 0.36%)}	_~	_27.63s	_27.87s	_{p=0.173 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_510,573	_510,573	_~	_~	_~	_{p=1.000 n=6}
_Types	_161,621	_161,621	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{448,203k (± 0.09%)}	_{448,328k (± 0.08%)}	_~	_447,792k	_448,626k	_{p=0.748 n=6}
_{Parse Time}	_{3.16s (± 0.74%)}	_{3.17s (± 0.94%)}	_~	_3.13s	_3.20s	_{p=0.514 n=6}
_{Bind Time}	_{1.18s (± 1.25%)}	_{1.17s (± 0.44%)}	_~	_1.16s	_1.17s	_{p=0.210 n=6}
_{Check Time}	_{17.16s (± 0.45%)}	_{17.18s (± 0.45%)}	_~	_17.05s	_17.29s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.49s (± 0.38%)}	_{21.52s (± 0.50%)}	_~	_21.35s	_21.66s	_{p=0.872 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-19T07:10:07Z

@iisaduan Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59352/merge:

Something interesting changed - please have a look.

Details

ag-grid/ag-grid

31 of 110 projects failed to build with the old tsc and were ignored

compiler-explorer/compiler-explorer

2 of 6 projects failed to build with the old tsc and were ignored

tsconfig.tests.json

error TS18046: 'a' is of type 'unknown'.
- shared/common-utils.ts#L55
- shared/common-utils.ts#L57
error TS18046: 'b' is of type 'unknown'.
- shared/common-utils.ts#L55
- shared/common-utils.ts#L57

tsconfig.json

error TS18046: 'a' is of type 'unknown'.
- shared/common-utils.ts#L55
- shared/common-utils.ts#L57
error TS18046: 'b' is of type 'unknown'.
- shared/common-utils.ts#L55
- shared/common-utils.ts#L57

static/tsconfig.json

error TS18046: 'a' is of type 'unknown'.
- shared/common-utils.ts#L55
- shared/common-utils.ts#L57
error TS18046: 'b' is of type 'unknown'.
- shared/common-utils.ts#L55
- shared/common-utils.ts#L57

desktop/desktop

1 of 4 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS18046: 'x' is of type 'unknown'.
error TS18046: 'y' is of type 'unknown'.

discordjs/discord.js

39 of 62 projects failed to build with the old tsc and were ignored

packages/collection/tsconfig.json

error TS18046: 'firstValue' is of type 'unknown'.
- packages/collection/src/collection.ts#L992
error TS18046: 'secondValue' is of type 'unknown'.
- packages/collection/src/collection.ts#L992

packages/collection/tsconfig.eslint.json

error TS18046: 'firstValue' is of type 'unknown'.
- packages/collection/src/collection.ts#L992
error TS18046: 'secondValue' is of type 'unknown'.
- packages/collection/src/collection.ts#L992

packages/collection/tsconfig.docs.json

error TS18046: 'firstValue' is of type 'unknown'.
- packages/collection/src/collection.ts#L992
error TS18046: 'secondValue' is of type 'unknown'.
- packages/collection/src/collection.ts#L992

mui/material-ui

29 of 81 projects failed to build with the old tsc and were ignored

docs/tsconfig.json

error TS2571: Object is of type 'unknown'.

sequelize/sequelize

13 of 16 projects failed to build with the old tsc and were ignored

packages/utils/tsconfig.json

error TS18046: 'a' is of type 'unknown'.
- packages/utils/src/common/comparators/basic-comparator.ts#L21
- packages/utils/src/common/comparators/basic-comparator.ts#L25
error TS18046: 'b' is of type 'unknown'.
- packages/utils/src/common/comparators/basic-comparator.ts#L21
- packages/utils/src/common/comparators/basic-comparator.ts#L25

tests/baselines/reference/unconstrainedTypeComparison.errors.txt

gabritto · 2024-07-19T20:18:30Z

src/compiler/checker.ts


+ // use to determine if a parameter may be undefined or null (or is unknown/unconstrained)
+ function getUnknownIfMaybeUnknown(type: Type){
+ return (strictNullChecks && type.flags & TypeFlags.Instantiable) ? getBaseConstraintOfType(type) || unknownType : type;


I'm assuming from #59059 that making this change to getTypeFacts breaks a lot of existing code, is that right?
Also, does making this change to checkNonNullType instead also break a lot of code?

Yes, I tried that and putting this change directly into checkNonNullType gets a very similar result to #59059 in terms of breaking object index checking

A lot of the cases that break relate to this type of index access #59059 (comment)

I don't know if this it's noticeably different in semantics, but istead of doing this, you might want to try to modify getBaseTypeOfLiteralTypeForComparison and rename it getBaseTypeForComparison. Then pass the result of that into checkNonNullType.

I would also consider renaming this to getBaseConstraintOrUnknown, use ?? instead of ||, and just get rid of the strictNullChecks check.

Also - any clue if this works on unions of unconstrained type parameters? Can you add a test?
functionf<T,U>(x: T|U,y: T|U){returnx<y;}

DanielRosenwasser · 2024-07-20T00:47:06Z

Checking this

@typescript-bot perf test this

typescript-bot · 2024-07-20T00:47:10Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

DanielRosenwasser · 2024-07-20T00:52:11Z

src/compiler/checker.ts


+ // use to determine if a parameter may be undefined or null (or is unknown/unconstrained)
+ function getUnknownIfMaybeUnknown(type: Type){
+ return (strictNullChecks && type.flags & TypeFlags.Instantiable) ? getBaseConstraintOfType(type) || unknownType : type;


I don't know if this it's noticeably different in semantics, but istead of doing this, you might want to try to modify getBaseTypeOfLiteralTypeForComparison and rename it getBaseTypeForComparison. Then pass the result of that into checkNonNullType.

DanielRosenwasser · 2024-07-20T00:54:42Z

src/compiler/checker.ts


+ // use to determine if a parameter may be undefined or null (or is unknown/unconstrained)
+ function getUnknownIfMaybeUnknown(type: Type){
+ return (strictNullChecks && type.flags & TypeFlags.Instantiable) ? getBaseConstraintOfType(type) || unknownType : type;


I would also consider renaming this to getBaseConstraintOrUnknown, use ?? instead of ||, and just get rid of the strictNullChecks check.

DanielRosenwasser · 2024-07-20T00:55:53Z

src/compiler/checker.ts


+ // use to determine if a parameter may be undefined or null (or is unknown/unconstrained)
+ function getUnknownIfMaybeUnknown(type: Type){
+ return (strictNullChecks && type.flags & TypeFlags.Instantiable) ? getBaseConstraintOfType(type) || unknownType : type;


Also - any clue if this works on unions of unconstrained type parameters? Can you add a test?
functionf<T,U>(x: T|U,y: T|U){returnx<y;}

typescript-bot · 2024-07-20T01:31:24Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,514k (± 0.93%)}	_{194,037k (± 1.04%)}	_~	_191,979k	_195,930k	_{p=0.575 n=6}
_{Parse Time}	_{1.95s (± 0.50%)}	_{1.96s (± 1.05%)}	_~	_1.93s	_1.99s	_{p=0.869 n=6}
_{Bind Time}	_{1.06s (± 1.73%)}	_{1.05s (± 0.72%)}	_~	_1.04s	_1.06s	_{p=0.367 n=6}
_{Check Time}	_{13.96s (± 0.60%)}	_{13.98s (± 0.58%)}	_~	_13.86s	_14.09s	_{p=0.747 n=6}
_{Emit Time}	_{3.99s (± 1.06%)}	_{4.08s (± 4.18%)}	_~	_3.92s	_4.41s	_{p=0.296 n=6}
_{Total Time}	_{20.97s (± 0.46%)}	_{21.06s (± 0.68%)}	_~	_20.92s	_21.32s	_{p=0.468 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₁₇	_{🔻+10 (+142.86%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_945,532	_945,532	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,507	_409,507	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,076k (± 0.00%)}	_{1,221,066k (± 0.00%)}	_~	_1,220,987k	_1,221,112k	_{p=1.000 n=6}
_{Parse Time}	_{7.84s (± 0.44%)}	_{7.88s (± 0.54%)}	_~	_7.82s	_7.93s	_{p=0.173 n=6}
_{Bind Time}	_{2.22s (± 1.54%)}	_{2.21s (± 0.62%)}	_~	_2.19s	_2.23s	_{p=0.455 n=6}
_{Check Time}	_{36.36s (± 0.41%)}	_{36.36s (± 0.34%)}	_~	_36.20s	_36.56s	_{p=0.688 n=6}
_{Emit Time}	_{17.83s (± 0.57%)}	_{17.90s (± 0.97%)}	_~	_17.72s	_18.14s	_{p=0.575 n=6}
_{Total Time}	_{64.26s (± 0.38%)}	_{64.34s (± 0.29%)}	_~	_64.08s	_64.57s	_{p=0.689 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₁₆	_{🔻+16 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_2,276,293	_2,276,293	_~	_~	_~	_{p=1.000 n=6}
_Types	_949,028	_949,008	_{-20 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,208,070k (± 0.00%)}	_{2,208,060k (± 0.00%)}	_~	_2,207,931k	_2,208,140k	_{p=0.689 n=6}
_{Parse Time}	_{9.64s (± 0.36%)}	_{9.67s (± 0.42%)}	_~	_9.62s	_9.73s	_{p=0.295 n=6}
_{Bind Time}	_{3.36s (± 0.69%)}	_{3.37s (± 1.46%)}	_~	_3.30s	_3.45s	_{p=0.686 n=6}
_{Check Time}	_{105.65s (± 0.50%)}	_{105.04s (± 1.44%)}	_~	_101.99s	_106.12s	_{p=0.471 n=6}
_{Emit Time}	_{0.21s (± 4.71%)}	_{0.21s (± 3.95%)}	_~	_0.20s	_0.22s	_{p=0.862 n=6}
_{Total Time}	_{118.86s (± 0.47%)}	_{118.27s (± 1.26%)}	_~	_115.27s	_119.32s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,400	_1,230,402	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,743	_265,744	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,348,382k (± 0.03%)}	_{2,347,304k (± 0.03%)}	_{-1,079k (- 0.05%)}	_2,346,190k	_2,348,045k	_{p=0.020 n=6}
_{Parse Time}	_{7.57s (± 0.92%)}	_{7.54s (± 0.73%)}	_~	_7.47s	_7.63s	_{p=0.575 n=6}
_{Bind Time}	_{2.80s (± 0.54%)}	_{2.79s (± 0.53%)}	_~	_2.77s	_2.80s	_{p=0.296 n=6}
_{Check Time}	_{50.24s (± 0.30%)}	_{50.37s (± 0.75%)}	_~	_49.98s	_51.02s	_{p=0.689 n=6}
_{Emit Time}	_{4.86s (± 3.31%)}	_{4.93s (± 2.34%)}	_~	_4.80s	_5.11s	_{p=0.378 n=6}
_{Total Time}	_{65.48s (± 0.28%)}	_{65.63s (± 0.67%)}	_~	_65.13s	_66.43s	_{p=0.470 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,400	_1,230,402	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,743	_265,744	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,420,996k (± 0.02%)}	_{2,420,837k (± 0.01%)}	_~	_2,420,310k	_2,421,277k	_{p=0.471 n=6}
_{Parse Time}	_{5.28s (± 0.82%)}	_{5.31s (± 0.30%)}	_~	_5.30s	_5.34s	_{p=0.261 n=6}
_{Bind Time}	_{1.70s (± 0.32%)}	_{1.69s (± 0.61%)}	_~	_1.68s	_1.70s	_{p=0.147 n=6}
_{Check Time}	_{35.09s (± 0.37%)}	_{35.09s (± 0.17%)}	_~	_35.03s	_35.20s	_{p=0.936 n=6}
_{Emit Time}	_{3.38s (± 1.88%)}	_{3.39s (± 1.09%)}	_~	_3.36s	_3.45s	_{p=1.000 n=6}
_{Total Time}	_{45.43s (± 0.25%)}	_{45.47s (± 0.09%)}	_~	_45.41s	_45.54s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,792	_258,794	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,554	_105,555	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,546k (± 0.03%)}	_{428,566k (± 0.02%)}	_~	_428,464k	_428,718k	_{p=0.689 n=6}
_{Parse Time}	_{3.35s (± 0.76%)}	_{3.36s (± 0.77%)}	_~	_3.32s	_3.39s	_{p=0.627 n=6}
_{Bind Time}	_{1.32s (± 0.57%)}	_{1.32s (± 1.33%)}	_~	_1.29s	_1.34s	_{p=0.196 n=6}
_{Check Time}	_{18.03s (± 0.55%)}	_{18.05s (± 0.43%)}	_~	_17.93s	_18.17s	_{p=0.936 n=6}
_{Emit Time}	_{1.65s (± 1.07%)}	_{1.64s (± 0.86%)}	_~	_1.62s	_1.66s	_{p=0.677 n=6}
_{Total Time}	_{24.35s (± 0.40%)}	_{24.37s (± 0.38%)}	_~	_24.27s	_24.52s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,029k (± 0.04%)}	_{370,082k (± 0.05%)}	_~	_369,841k	_370,313k	_{p=0.575 n=6}
_{Parse Time}	_{3.45s (± 1.24%)}	_{3.43s (± 0.40%)}	_~	_3.42s	_3.45s	_{p=0.568 n=6}
_{Bind Time}	_{1.91s (± 1.07%)}	_{1.91s (± 0.61%)}	_~	_1.90s	_1.93s	_{p=1.000 n=6}
_{Check Time}	_{19.24s (± 0.53%)}	_{19.29s (± 0.19%)}	_~	_19.24s	_19.34s	_{p=0.126 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.61s (± 0.58%)}	_{24.64s (± 0.16%)}	_~	_24.60s	_24.71s	_{p=0.334 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,978,923	_2,978,923	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,024,932	_1,024,932	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,104,101k (± 0.00%)}	_{3,104,077k (± 0.00%)}	_~	_3,104,022k	_3,104,106k	_{p=0.630 n=6}
_{Parse Time}	_{13.92s (± 0.31%)}	_{13.89s (± 0.34%)}	_~	_13.82s	_13.95s	_{p=0.332 n=6}
_{Bind Time}	_{4.29s (± 0.28%)}	_{4.30s (± 0.35%)}	_~	_4.27s	_4.31s	_{p=0.218 n=6}
_{Check Time}	_{79.32s (± 0.33%)}	_{79.13s (± 0.30%)}	_~	_78.71s	_79.36s	_{p=0.810 n=6}
_{Emit Time}	_{20.54s (± 0.57%)}	_{20.49s (± 0.29%)}	_~	_20.44s	_20.60s	_{p=0.376 n=6}
_{Total Time}	_{118.07s (± 0.19%)}	_{117.80s (± 0.15%)}	_{-0.27s (- 0.23%)}	_117.54s	_118.01s	_{p=0.045 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,602	_267,602	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,105	_109,105	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,322k (± 0.01%)}	_{412,295k (± 0.02%)}	_~	_412,176k	_412,391k	_{p=0.689 n=6}
_{Parse Time}	_{3.83s (± 0.54%)}	_{3.83s (± 0.39%)}	_~	_3.82s	_3.86s	_{p=1.000 n=6}
_{Bind Time}	_{1.71s (± 0.48%)}	_{1.71s (± 1.02%)}	_~	_1.68s	_1.73s	_{p=0.605 n=6}
_{Check Time}	_{16.80s (± 0.30%)}	_{16.77s (± 0.44%)}	_~	_16.68s	_16.86s	_{p=0.421 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.34s (± 0.28%)}	_{22.32s (± 0.34%)}	_~	_22.22s	_22.41s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_511,803	_511,803	_~	_~	_~	_{p=1.000 n=6}
_Types	_162,088	_162,088	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{449,026k (± 0.07%)}	_{449,068k (± 0.08%)}	_~	_448,602k	_449,376k	_{p=0.810 n=6}
_{Parse Time}	_{3.89s (± 0.32%)}	_{3.91s (± 0.86%)}	_~	_3.88s	_3.97s	_{p=0.250 n=6}
_{Bind Time}	_{1.44s (± 1.04%)}	_{1.44s (± 0.81%)}	_~	_1.42s	_1.45s	_{p=0.616 n=6}
_{Check Time}	_{21.23s (± 0.16%)}	_{21.27s (± 0.44%)}	_~	_21.14s	_21.36s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.56s (± 0.15%)}	_{26.61s (± 0.38%)}	_~	_26.46s	_26.72s	_{p=0.261 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,758ms (± 1.21%)}	_{2,878ms (± 9.31%)}	_~	_2,757ms	_3,425ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{6,822ms (±10.70%)}	_{7,056ms (± 9.52%)}	_~	_6,172ms	_7,602ms	_{p=0.575 n=6}
_{Req 3 - references}	_{368ms (±10.59%)}	_{392ms (± 0.25%)}	_~	_391ms	_393ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{339ms (± 0.12%)}	_{339ms (± 0.69%)}	_~	_334ms	_340ms	_{p=0.546 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{128ms (± 7.04%)}	_{127ms (± 5.80%)}	_~	_121ms	_136ms	_{p=0.570 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,573ms (± 0.97%)}	_{3,577ms (± 0.88%)}	_~	_3,515ms	_3,602ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{5,687ms (± 0.52%)}	_{5,677ms (± 0.45%)}	_~	_5,645ms	_5,718ms	_{p=0.575 n=6}
_{Req 3 - references}	_{413ms (± 1.13%)}	_{409ms (± 1.51%)}	_~	_400ms	_419ms	_{p=0.328 n=6}
_{Req 4 - navto}	_{341ms (± 1.59%)}	_{342ms (± 2.76%)}	_~	_336ms	_361ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{124ms (± 0.66%)}	_{117ms (± 8.98%)}	_~	_100ms	_125ms	_{p=0.402 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,352ms (± 4.95%)}	_{6,474ms (± 6.06%)}	_~	_6,201ms	_7,006ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{1,664ms (± 0.98%)}	_{1,493ms (±12.49%)}	_~	_1,307ms	_1,691ms	_{p=0.149 n=6}
_{Req 3 - references}	_{127ms (± 5.01%)}	_{126ms (± 9.18%)}	_~	_103ms	_134ms	_{p=0.560 n=6}
_{Req 4 - navto}	_{597ms (± 1.59%)}	_{605ms (± 0.93%)}	_~	_600ms	_616ms	_{p=0.077 n=6}
_{Req 5 - completionInfo count}	_3,417	_3,417	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,243ms (± 1.30%)}	_{1,240ms (± 1.71%)}	_~	_1,198ms	_1,255ms	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{190.28ms (± 0.16%)}	_{190.25ms (± 0.18%)}	_~	_188.48ms	_195.26ms	_{p=0.109 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{346.36ms (± 0.28%)}	_{346.16ms (± 0.29%)}	_{-0.20ms (- 0.06%)}	_337.79ms	_353.31ms	_{p=0.002 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{277.64ms (± 0.28%)}	_{277.76ms (± 0.28%)}	_{+0.12ms (+ 0.04%)}	_270.74ms	_282.26ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{278.33ms (± 0.29%)}	_{278.13ms (± 0.28%)}	_{-0.20ms (- 0.07%)}	_271.29ms	_284.76ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

iisaduan · 2024-07-22T17:00:53Z

@DanielRosenwasser Thanks for the suggestions! Good catch--it does work for unions but not intersections, so I added those cases as well.

gabritto · 2024-07-23T18:43:33Z

@typescript-bot test it

typescript-bot · 2024-07-23T18:43:37Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-23T19:04:36Z

@gabritto Here are the results of running the user tests with tsc comparing main and refs/pull/59352/merge:

Everything looks good!

typescript-bot · 2024-07-23T19:05:46Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-23T19:20:07Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,300k (± 0.01%)}	_{192,912k (± 0.73%)}	_{+612k (+ 0.32%)}	_192,286k	_195,807k	_{p=0.045 n=6}
_{Parse Time}	_{1.57s (± 0.96%)}	_{1.57s (± 1.04%)}	_~	_1.55s	_1.59s	_{p=0.801 n=6}
_{Bind Time}	_{0.86s (± 1.04%)}	_{0.86s (± 1.40%)}	_~	_0.85s	_0.88s	_{p=0.676 n=6}
_{Check Time}	_{11.35s (± 0.51%)}	_{11.37s (± 0.73%)}	_~	_11.27s	_11.47s	_{p=0.467 n=6}
_{Emit Time}	_{3.27s (± 0.46%)}	_{3.28s (± 0.92%)}	_~	_3.25s	_3.33s	_{p=1.000 n=6}
_{Total Time}	_{17.05s (± 0.37%)}	_{17.09s (± 0.63%)}	_~	_16.96s	_17.20s	_{p=0.378 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₁₇	_{🔻+10 (+142.86%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_945,532	_945,532	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,507	_409,507	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,136k (± 0.01%)}	_{1,221,123k (± 0.00%)}	_~	_1,221,042k	_1,221,176k	_{p=0.470 n=6}
_{Parse Time}	_{6.59s (± 0.86%)}	_{6.62s (± 0.15%)}	_~	_6.60s	_6.63s	_{p=0.370 n=6}
_{Bind Time}	_{1.85s (± 0.41%)}	_{1.85s (± 0.59%)}	_~	_1.83s	_1.86s	_{p=1.000 n=6}
_{Check Time}	_{31.01s (± 0.15%)}	_{31.08s (± 0.24%)}	_~	_30.99s	_31.21s	_{p=0.077 n=6}
_{Emit Time}	_{15.02s (± 0.53%)}	_{15.08s (± 0.44%)}	_~	_15.01s	_15.18s	_{p=0.377 n=6}
_{Total Time}	_{54.48s (± 0.24%)}	_{54.63s (± 0.23%)}	_~	_54.54s	_54.87s	_{p=0.128 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₁₆	_{🔻+16 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_2,276,404	_2,276,404	_~	_~	_~	_{p=1.000 n=6}
_Types	_949,156	_949,136	_{-20 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,208,290k (± 0.00%)}	_{2,208,352k (± 0.00%)}	_~	_2,208,292k	_2,208,411k	_{p=0.054 n=6}
_{Parse Time}	_{6.60s (± 0.34%)}	_{6.59s (± 0.32%)}	_~	_6.55s	_6.61s	_{p=1.000 n=6}
_{Bind Time}	_{2.32s (± 0.32%)}	_{2.32s (± 0.39%)}	_~	_2.31s	_2.33s	_{p=0.798 n=6}
_{Check Time}	_{72.84s (± 0.16%)}	_{72.84s (± 0.27%)}	_~	_72.58s	_73.06s	_{p=0.809 n=6}
_{Emit Time}	_{0.14s (± 5.31%)}	_{0.14s (± 2.95%)}	_~	_0.13s	_0.14s	_{p=0.389 n=6}
_{Total Time}	_{81.90s (± 0.15%)}	_{81.89s (± 0.27%)}	_~	_81.58s	_82.11s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,067	_1,231,070	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,104	_266,105	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,349,063k (± 0.02%)}	_{2,407,907k (± 6.03%)}	_~	_2,347,883k	_2,704,372k	_{p=0.575 n=6}
_{Parse Time}	_{5.09s (± 1.07%)}	_{5.08s (± 1.40%)}	_~	_4.99s	_5.15s	_{p=0.520 n=6}
_{Bind Time}	_{1.91s (± 0.54%)}	_{1.89s (± 0.65%)}	_{-0.02s (- 1.14%)}	_1.86s	_1.89s	_{p=0.010 n=6}
_{Check Time}	_{34.75s (± 0.61%)}	_{34.64s (± 0.72%)}	_~	_34.20s	_34.88s	_{p=0.630 n=6}
_{Emit Time}	_{3.29s (± 1.99%)}	_{3.28s (± 1.90%)}	_~	_3.21s	_3.38s	_{p=0.936 n=6}
_{Total Time}	_{45.04s (± 0.56%)}	_{44.90s (± 0.55%)}	_~	_44.49s	_45.17s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,067	_1,231,070	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,104	_266,105	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,422,907k (± 0.02%)}	_{2,423,044k (± 0.02%)}	_~	_2,422,530k	_2,423,663k	_{p=0.810 n=6}
_{Parse Time}	_{6.34s (± 0.85%)}	_{6.30s (± 0.52%)}	_~	_6.26s	_6.34s	_{p=0.230 n=6}
_{Bind Time}	_{2.04s (± 0.90%)}	_{2.04s (± 0.31%)}	_~	_2.03s	_2.05s	_{p=0.627 n=6}
_{Check Time}	_{41.36s (± 0.30%)}	_{41.39s (± 0.24%)}	_~	_41.24s	_41.48s	_{p=0.748 n=6}
_{Emit Time}	_{4.03s (± 1.22%)}	_{3.96s (± 1.01%)}	_{-0.07s (- 1.65%)}	_3.89s	_4.01s	_{p=0.013 n=6}
_{Total Time}	_{53.78s (± 0.33%)}	_{53.70s (± 0.23%)}	_~	_53.55s	_53.82s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,215	_259,218	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,867	_105,868	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{429,634k (± 0.03%)}	_{429,611k (± 0.02%)}	_~	_429,570k	_429,742k	_{p=0.936 n=6}
_{Parse Time}	_{3.35s (± 0.53%)}	_{3.36s (± 0.59%)}	_~	_3.34s	_3.39s	_{p=0.871 n=6}
_{Bind Time}	_{1.32s (± 1.24%)}	_{1.33s (± 0.91%)}	_~	_1.31s	_1.34s	_{p=0.300 n=6}
_{Check Time}	_{18.09s (± 0.30%)}	_{18.11s (± 0.17%)}	_~	_18.07s	_18.15s	_{p=0.520 n=6}
_{Emit Time}	_{1.62s (± 1.89%)}	_{1.64s (± 0.51%)}	_~	_1.62s	_1.64s	_{p=0.452 n=6}
_{Total Time}	_{24.39s (± 0.30%)}	_{24.44s (± 0.18%)}	_~	_24.39s	_24.50s	_{p=0.296 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,151k (± 0.03%)}	_{370,137k (± 0.01%)}	_~	_370,069k	_370,204k	_{p=0.575 n=6}
_{Parse Time}	_{2.75s (± 1.08%)}	_{2.76s (± 0.53%)}	_~	_2.74s	_2.78s	_{p=0.870 n=6}
_{Bind Time}	_{1.58s (± 1.06%)}	_{1.58s (± 1.18%)}	_~	_1.56s	_1.61s	_{p=0.681 n=6}
_{Check Time}	_{15.66s (± 0.19%)}	_{15.62s (± 0.16%)}	_{-0.04s (- 0.24%)}	_15.58s	_15.64s	_{p=0.028 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.99s (± 0.16%)}	_{19.96s (± 0.07%)}	_~	_19.94s	_19.97s	_{p=0.062 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,986,643	_2,986,643	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,027,511	_1,027,511	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,111,141k (± 0.00%)}	_{3,111,087k (± 0.00%)}	_~	_3,111,031k	_3,111,198k	_{p=0.128 n=6}
_{Parse Time}	_{13.80s (± 0.34%)}	_{13.83s (± 0.30%)}	_~	_13.78s	_13.89s	_{p=0.574 n=6}
_{Bind Time}	_{4.29s (± 0.50%)}	_{4.33s (± 2.20%)}	_~	_4.27s	_4.52s	_{p=1.000 n=6}
_{Check Time}	_{79.24s (± 0.17%)}	_{79.36s (± 0.49%)}	_~	_78.86s	_79.98s	_{p=0.689 n=6}
_{Emit Time}	_{20.50s (± 0.73%)}	_{20.50s (± 0.52%)}	_~	_20.31s	_20.61s	_{p=1.000 n=6}
_{Total Time}	_{117.84s (± 0.21%)}	_{118.01s (± 0.34%)}	_~	_117.70s	_118.74s	_{p=0.630 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,603	_267,603	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,105	_109,105	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,306k (± 0.01%)}	_{412,379k (± 0.02%)}	_~	_412,292k	_412,485k	_{p=0.093 n=6}
_{Parse Time}	_{3.18s (± 0.65%)}	_{3.18s (± 0.28%)}	_~	_3.17s	_3.19s	_{p=0.807 n=6}
_{Bind Time}	_{1.43s (± 0.72%)}	_{1.43s (± 0.29%)}	_~	_1.42s	_1.43s	_{p=0.268 n=6}
_{Check Time}	_{14.26s (± 0.28%)}	_{14.27s (± 0.57%)}	_~	_14.15s	_14.35s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.88s (± 0.17%)}	_{18.88s (± 0.42%)}	_~	_18.76s	_18.97s	_{p=0.687 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_511,803	_511,803	_~	_~	_~	_{p=1.000 n=6}
_Types	_162,088	_162,088	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{448,938k (± 0.08%)}	_{448,974k (± 0.09%)}	_~	_448,616k	_449,383k	_{p=0.936 n=6}
_{Parse Time}	_{3.91s (± 0.63%)}	_{3.91s (± 0.56%)}	_~	_3.88s	_3.94s	_{p=1.000 n=6}
_{Bind Time}	_{1.45s (± 0.36%)}	_{1.44s (± 0.72%)}	_~	_1.42s	_1.45s	_{p=0.070 n=6}
_{Check Time}	_{21.25s (± 0.21%)}	_{21.21s (± 0.39%)}	_~	_21.09s	_21.33s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.61s (± 0.15%)}	_{26.56s (± 0.40%)}	_~	_26.40s	_26.71s	_{p=0.336 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-23T20:47:29Z

@gabritto Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59352/merge:

Something interesting changed - please have a look.

Details

ag-grid/ag-grid

31 of 110 projects failed to build with the old tsc and were ignored

enterprise-modules/viewport-row-model/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/viewport-row-model/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/status-bar/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/status-bar/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/sparklines/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/sparklines/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/side-bar/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/side-bar/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/set-filter/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/set-filter/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/server-side-row-model/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/server-side-row-model/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/row-grouping/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/row-grouping/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/rich-select/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/rich-select/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/range-selection/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/range-selection/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/multi-filter/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/multi-filter/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/master-detail/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/master-detail/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/filter-tool-panel/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/filter-tool-panel/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/core/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/core/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/advanced-filter/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

enterprise-modules/advanced-filter/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/vue3/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/vue3/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/infinite-row-model/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/infinite-row-model/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/csv-export/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/csv-export/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/core/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/core/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/client-side-row-model/tsconfig.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

community-modules/client-side-row-model/tsconfig.types.watch.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126
error TS18049: 'b' is possibly 'null' or 'undefined'.
- community-modules/core/src/utils/generic.ts#L126
- community-modules/core/src/utils/generic.ts#L126

compiler-explorer/compiler-explorer

4 of 6 projects failed to build with the old tsc and were ignored

static/tsconfig.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- shared/common-utils.ts#L55
- shared/common-utils.ts#L57
error TS18049: 'b' is possibly 'null' or 'undefined'.
- shared/common-utils.ts#L55
- shared/common-utils.ts#L57

desktop/desktop

1 of 4 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS18049: 'x' is possibly 'null' or 'undefined'.
error TS18049: 'y' is possibly 'null' or 'undefined'.

sequelize/sequelize

13 of 16 projects failed to build with the old tsc and were ignored

packages/utils/tsconfig.json

error TS18049: 'a' is possibly 'null' or 'undefined'.
- packages/utils/src/common/comparators/basic-comparator.ts#L21
- packages/utils/src/common/comparators/basic-comparator.ts#L25
error TS18049: 'b' is possibly 'null' or 'undefined'.
- packages/utils/src/common/comparators/basic-comparator.ts#L21
- packages/utils/src/common/comparators/basic-comparator.ts#L25

ahejlsberg · 2024-07-26T21:30:08Z

I have just put up #59437 which I believe is the right fix for #50603 plus the inconsistencies related to unconstrained type parameters vs. type parameters constrained to {} | null | undefined. There are an awful lot of interacting parts here. In particular, it only becomes feasible to check that unconstrained generic types are possibly nullable in --strictNullChecks mode by first fixing the fact that obj shouldn't be null-checked in obj[key] when obj and key both have generic types.

add check for >, >=, <, <= for unconstrained types
ee33225

iisaduan marked this pull request as ready for review July 19, 2024 03:34

fmt
fca2ca0

iisaduan changed the title ~~consistently check for >, >=, <, <= for unconstrained types with strictNullChecks~~consistently check expressions with >, >=, <, <= for unconstrained types with strictNullChecksJul 19, 2024

iisaduan changed the title ~~consistently check expressions with >, >=, <, <= for unconstrained types with strictNullChecks~~consistently check expressions with >, >=, <, <= for unconstrained types in strictNullChecksJul 19, 2024

iisaduan requested review from andrewbranch, gabritto and weswigham July 19, 2024 19:02

andrewbranch reviewed Jul 19, 2024
View reviewed changes

tests/baselines/reference/unconstrainedTypeComparison.errors.txt Outdated Show resolvedHide resolved

gabritto reviewed Jul 19, 2024
View reviewed changes

change error to possibly null or undefined
1fa487e

gabritto previously approved these changes Jul 19, 2024
View reviewed changes

DanielRosenwasser requested changes Jul 20, 2024
View reviewed changes

ahejlsberg mentioned this pull request Jul 22, 2024
unconstrained type parameters are consistently checked for {} | null | undefined in strictNullChecks#59059
Open

iisaduan added 2 commits July 22, 2024 09:48

add intersections
0308dde

add tests, fix comment
43c24bb

format
529331b

weswigham approved these changes Jul 23, 2024
View reviewed changes

ahejlsberg added a commit that referenced this pull request Jul 26, 2024
Include tests from#59352
2e02dc4

iisaduan dismissed gabritto’s stale review via 529331bApril 1, 2025 16:34

consistently check expressions with >, >=, <, <= for unconstrained types in strictNullChecks#59352

Are you sure you want to change the base?

consistently check expressions with >, >=, <, <= for unconstrained types in strictNullChecks #59352

Uh oh!

Conversation

iisaduan commented Jul 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iisaduan commented Jul 19, 2024

Uh oh!

typescript-bot commented Jul 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 19, 2024

Uh oh!

typescript-bot commented Jul 19, 2024

Uh oh!

typescript-bot commented Jul 19, 2024

tsc

Uh oh!

typescript-bot commented Jul 19, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iisaduanJul 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser commented Jul 20, 2024

Uh oh!

typescript-bot commented Jul 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Jul 20, 2024

tsc

tsserver

startup

Uh oh!

iisaduan commented Jul 22, 2024

Uh oh!

gabritto commented Jul 23, 2024

Uh oh!

typescript-bot commented Jul 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 23, 2024

Uh oh!

typescript-bot commented Jul 23, 2024

Uh oh!

typescript-bot commented Jul 23, 2024

tsc

Uh oh!

typescript-bot commented Jul 23, 2024

iisaduan commented Jul 19, 2024•
edited
Loading

typescript-bot commented Jul 19, 2024•
edited
Loading

typescript-bot commented Jul 19, 2024•
edited
Loading

iisaduanJul 19, 2024•
edited
Loading

typescript-bot commented Jul 20, 2024•
edited
Loading

typescript-bot commented Jul 23, 2024•
edited
Loading