optimization, reduce memory usage#61822
Merged
+2 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
typescript-bot added For Uncommitted Bug Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes initialization by removing unnecessary lambda wrappers that were previously creating extra function objects, resulting in reduced memory usage and a faster startup for tsserver in large repositories.
- Removed lambda wrapper functions in fileOrDirectoryExistsUsingSource for direct function calls.
- Achieves an 11% improvement in initialization time.
VincentBaillyforce-pushed the optimize-memory-remove-lambdas branch from 53f3158 to 3af1111Compare
Member
jakebailey commented Jun 6, 2025
I'm shocked this matters, the runtime is pretty good about inlining this sort of thing. How did you determine your stats? |
jakebailey approved these changes Jun 6, 2025
Member
jakebailey left a comment
jakebailey left a comment There was a problem hiding this comment.
Of course, this does seem fine.
RyanCavanaugh merged commit 97cfa26 into microsoft:main 32 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the creation of unnecessary lambda wrappers.
Speeds up 11% the project initialization time of tsserver in large repositories.
Fixes#61821