Remove explicitly setting PreferredToolArchitecture, since VS 2022 handles this more comprehensively#1304
Uh oh!
There was an error while loading. Please reload this page.
Conversation
…ndles this more comprehensively
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <PreferredToolArchitecture>x64</PreferredToolArchitecture> |
There was a problem hiding this comment.
Should this be scoped to the VS2022 build tools (so that VS2019 still gets it set)?
There was a problem hiding this comment.
Or the opposite; only set it for VS2019 and then VS2022+ do not set it because VS does the right thing already.
There was a problem hiding this comment.
I don't think the latest version of cppwinrt supports the 2019 compiler any longer.
There was a problem hiding this comment.
It's actually a bug to set it in VS2019 when building for ARM64 (reported elsewhere). And since it's just a build optimization, I think better to remove it altogether, than to effectively copy the intelligence in the VS 2022 Microsoft.Cpp.ToolsetLocation.props.
fixes#1302
With VS 2022, PreferredToolArchitecture is now set appropriately for every architecture (via Microsoft.Cpp.ToolsetLocation.props), so should no longer be set unconditionally by C++/WinRT