Clean up type system#439

MikhailArkhipov · 2018-11-29T19:06:34Z

Fixes#404

Make type derive properly, i.e. IPythonType => IPythonFunction, make module a type, etc.
Move class-specific methods to IPythonClass
Simplify implementation by using proper base classes like AstPythonTypeWrapper.
Reduce type complexity with functions/methods/bounded such as if function has declaring type, it is then a method, etc.
Fix couple tests with typings related to protocol derivation.
In most cases MemberId is now function of BuiltInTypeId for consistency.
Update few tests baselines with changed tooltips/information.

I will wait for #361 to go in first.

…-server into analysis2

src/LanguageServer/Impl/Implementation/CompletionAnalysis.cs

src/Analysis/Engine/Test/FluentAssertions/MemberContainerAssertionsExtensions.cs

AlexanderSher · 2018-11-29T19:30:34Z

src/Analysis/Engine/Test/AstAnalysisTests.cs

@@ -942,19 +945,13 @@ public async Task TypeShedJsonMakeScanner(){
 var analysis = await server.OpenDefaultDocumentAndGetAnalysisAsync(code);

 var v0 = analysis.Should().HaveVariable("scanner").WithValueAt<IBuiltinInstanceInfo>(0);


you probably don't need this variable anymore.

src/Analysis/Engine/Impl/Values/Protocols.cs

src/Analysis/Engine/Impl/Values/BuiltinInstanceInfo.cs

src/Analysis/Engine/Impl/Values/BuiltinFunctionInfo.cs

src/Analysis/Engine/Impl/Values/BuiltinClassInfo.cs

src/Analysis/Engine/Impl/PythonAnalyzer.cs

src/Analysis/Engine/Impl/OverloadResult.cs

src/Analysis/Engine/Impl/KnownTypes.cs

src/Analysis/Engine/Impl/Interpreter/Ast/AstPythonMultipleMembers.cs

src/Analysis/Engine/Impl/Interpreter/Ast/AstPythonClass.cs

src/LanguageServer/Impl/Implementation/CompletionAnalysis.cs

src/Analysis/Engine/Impl/Interpreter/Ast/AstBuiltinsPythonModule.cs

src/Analysis/Engine/Impl/Values/SequenceBuiltinInstanceInfo.cs

AlexanderSher · 2018-12-05T17:58:14Z

src/Analysis/Engine/Impl/Values/BuiltinInstanceInfo.cs

 get{
 IAnalysisSet callRes;
- if (_klass.GetAllMembers(ProjectState._defaultContext).TryGetValue("__call__", out callRes)){
+ if (ClassInfo.GetAllMembers(ProjectState._defaultContext).TryGetValue("__call__", out callRes)){


In TypeId, ClassInfo is checked for null, and here it isn't. Which one is correct?

I checked ctor calls and I don't see how it can be null. And what would be the legal scenario for the null case...

* Types hierarchy cleanup * Test fixes, part I * Restore IPythonBoundFunction * Fix function instance types * More fixes * Fix overload handling * Fix properties * Fix type factory * Remove class built-in type * Simplify builtins, remove obsolete method * Fix typeshed merge * Allow declaring module to be null * Correct assertion * Simplify functions/methods * Fix stub merge tests * Fix tests * Baselines * Null ref * Build break * Overrides signatures * Fix typeinfo tests * PR feedback * Better handle overloads * Build breaks * Baselines * PR fix * PR feedback * Merge conflict * Fixmicrosoft#446 * Fixmicrosoft#446

Mikhail Arkhipov added 23 commits November 14, 2018 15:15

Types hierarchy cleanup
8bd5303

Test fixes, part I
7cd781f

Restore IPythonBoundFunction
91bde57

Fix function instance types
07ec4d4

More fixes
1be750c

Fix overload handling
0322c43

Fix properties
804a460

Fix type factory
b9fbe7a

Remove class built-in type
49afe21

Simplify builtins, remove obsolete method
3f855ac

Fix typeshed merge
2df9c05

Merge master
c663ce8

Allow declaring module to be null
a2eb6f2

Correct assertion
133faaa

Simplify functions/methods
3ba26fc

Fix stub merge tests
4986aaf

Fix tests
37c2830

Merge branch 'master' ofhttps://github.com/Microsoft/python-language…
dccd44d
…-server into analysis2

Baselines
ad459bb

Null ref
dab1e22

Build break
ca5aecf

Overrides signatures
bf1d77c

Fix typeinfo tests
90e06d7