This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix various common exceptions, log on a failed directory load#498
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… files, fix nullref when shutting down without an idle tracker
Uh oh!
There was an error while loading. Please reload this page.
MikhailArkhipov approved these changes Dec 21, 2018
MemberAuthor
jakebailey commented Dec 21, 2018
Any comment on my TODO at the bottom of the PR? |
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Dec 22, 2018
AlexanderSher pushed a commit to AlexanderSher/python-language-server that referenced this pull request Feb 4, 2019
…oft#498) * rethrow exception after telemetry instead of disposing * log an error instead of crashing when hitting some exceptions loading files, fix nullref when shutting down without an idle tracker * fix short circuiting of question mark checks to prevent null from being returned * print name of exception instead of relying on ToString * don't use MaybeEnumerate * upgrade message to Show
AlexanderSher added a commit that referenced this pull request Feb 4, 2019
* Fix#470 (#478) * Fix various common exceptions, log on a failed directory load (#498) * rethrow exception after telemetry instead of disposing * log an error instead of crashing when hitting some exceptions loading files, fix nullref when shutting down without an idle tracker * fix short circuiting of question mark checks to prevent null from being returned * print name of exception instead of relying on ToString * don't use MaybeEnumerate * upgrade message to Show * Mitigate some of #495 via MRO member selection and analysis set optimization (#517) This isn't a complete fix, but does seem to improve #495 in some cases. Adds back the early MRO return removed in #277, so now large class hierarchies won't over-propagate types (where some of the trouble with fastai happens do to the Transform class). I also optimized AnalysisHashSet a little to do length checks when possible. There are still times when things get caught up comparing unions for a while, but it seems to be nondeterministic. * Two path resolution bug fixes - Fix#509: PLS doesn't flag error in a relative import if it is found in another root directory (#519) - Fix#510: PLS doesn't resolve relative paths correctly * Catch exceptions when importing from search paths (#525) * catch exceptions when importing from search paths * retry instead of not found
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#448.
Fixes#463.
Fixes#440. (I didn't realize
?would short circuit. Found all mistakes withrg '\w+(\(\))?\?\.\w+\.Maybe')Also fixes the nullrefs coming from Shutdown.
Opening this PR into
release, but I can easily switch it tomaster(since they're even).There is one TODO I'd like feedback on, for the fix to #448.