Skip to content

Conversation

@abetomo
Copy link
Contributor

In preparation for a problem, processing that can be switched by environment variable is put in place.
If the next version has been released and there are no major problems, Replace with _fileCopy.

abetomo added 4 commits May 2, 2017 11:01
If there is a problem with `_ fileCopy`, it is possible to switch to `_rsync` in the environment variable
Copy link
Collaborator

@DeviaVirDeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, would it make sense to only use _fileCopy in the case of Windows, and rsync with other platforms? Is there an optimization to be had there?

@abetomo
Copy link
ContributorAuthor

@DeviaVir
According to the result of travis-ci, _ fileCopy seems to be a little bit faster.
(It does not measure strictly)
(It will be displayed as XX ms to the right of the test results when it took a long time to test.)

As the difference in speed is really small, should we use _rsync as usual except in Windows?
(There is also an advantage that the influence range is reduced, so will I fix it?)

@DeviaVir
Copy link
Collaborator

@abetomo long as fileCopy does not make it smaller, and indeed makes it faster, I'm fine with switching to that. Will merge this PR.

@DeviaVirDeviaVir merged commit 63d9020 into motdotla:masterMay 2, 2017
@abetomo
Copy link
ContributorAuthor

@DeviaVir Thank you!

@abetomoabetomo deleted the fix_to_replace_rsync_with_filecopy branch May 2, 2017 09:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@abetomo@DeviaVir