Skip to content

Conversation

@abetomo
Copy link
Contributor

abetomo added 8 commits May 16, 2017 14:12
Because Node.js 4.3 sometimes truncate on the way if the result size is large
Because the value changes on Windows and Linux.
Because it is not executed unless you explicitly specify the node command on Windows in case of executing in unit test.
Copy link
Collaborator

@DeviaVirDeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 that's a nice fix to have. I wonder about the http://docs.aws.amazon.com/lambda/latest/dg/nodejs-prog-model-context.html#nodejs-prog-model-context-propertiescallbackWaitsForEmptyEventLoop, should we support it?

@DeviaVirDeviaVir merged commit b285b41 into motdotla:masterMay 17, 2017
@abetomo
Copy link
ContributorAuthor

I have not used Lambda with callbackWaitsForEmptyEventLoop set to false and I will check it.
If it seems to be able to support, I will try to fix it. :-)

@abetomoabetomo deleted the fix_run_handler_callback branch May 18, 2017 06:07
@DeviaVirDeviaVir mentioned this pull request Jun 16, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@abetomo@DeviaVir