Skip to content

Refactoring lib/schedule_events.js#395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeviaVir merged 2 commits into from
Dec 11, 2017
Merged

Refactoring lib/schedule_events.js #395

DeviaVir merged 2 commits into from
Dec 11, 2017

Conversation

@abetomo
Copy link
Contributor

@abetomoabetomo commented Dec 9, 2017

  • Use reject
  • () Omitted

DeviaVir
DeviaVir approved these changes Dec 11, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVirDeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 promisifying

@DeviaVirDeviaVir merged commit c764b61 into motdotla:masterDec 11, 2017
@DeviaVirDeviaVir mentioned this pull request Dec 11, 2017
Merged
@abetomoabetomo deleted the clean_schedule_events.js_promise_chain branch December 12, 2017 21:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeviaVirDeviaVirDeviaVir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abetomo@DeviaVir