fix ce->name is a zend_string#125
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
remicollet commented Jun 26, 2018
7.3 work is not done, still have to fix the recursion protection... (I don't have it for now...) |
codecov-io commented Jun 26, 2018
Codecov Report
@@ Coverage Diff @@## master #125 +/- ## ========================================== - Coverage 87.36% 87.29% -0.07% ========================================== Files 8 8 Lines 1250 1251 +1 Branches 222 0 -222 ========================================== Hits 1092 1092 - Misses 158 159 +1
Continue to review full report at Codecov.
|
Contributor
Jan-E commented Jun 26, 2018
Is not that in the other PR for 7.3: |
ContributorAuthor
remicollet commented Jun 27, 2018
ContributorAuthor
remicollet commented Dec 20, 2018
@laruence sadly this one was not merged in 2.0.3 |
Contributor
Jan-E commented Dec 20, 2018
Time for a 2.0.4 |
m6w6 added a commit to m6w6/msgpack-php that referenced this pull request Dec 20, 2019
+ Improved performance + Upgraded bundled msgpack headers to 3.2.0 * Merged PR msgpack#101: Update README in order to match compatibile PHP version * Merged PR msgpack#125: fix ce->name is a zend_string * Merged PR msgpack#106: Update README * Merged PR msgpack#126: add mising tests in archive * Merged PR msgpack#135: Add fixes for issue msgpack#81 This also includes tests. * Merged PR msgpack#143: Fixed build with PHP-7.4 * Fixed issue msgpack#139: Segmentation fault when using cloned unpacker * Fixed issue msgpack#132: Segfault on session php7.3 * Fixed issue msgpack#107: $unpacker->execute() bug * Fixed issue msgpack#83: Arrays and negative index * Fixed issue msgpack#137: DateTime(Immutable) serialization doesn't work with php 7.4 RC1 * Fixed issue msgpack#105: MessagePackUnpacker() bug * Fixed issue msgpack#90: msgpack_unpack is super slow (30x times igbinary) on big data sets * Fixed issue msgpack#91: Private property in base class * Fixed issue msgpack#67: Integer overflow on a 64-bit system * Fixed issue msgpack#33: int64 and uint64 decode is not supported in 32-bit php * Fixed issue msgpack#119: uint64 numbers are cast to uint on Windows * Fixed issue msgpack#134: msgpack-php msgpack_serialize/msgpack_pack not handling properly large int * Fixed issue msgpack#81: Serialize optimization * Fixed issue msgpack#108: tests/041.phpt failure * Fixed issue msgpack#142: Recursion encoded as NULL * Fixed issue msgpack#138: Serializers comparison for session like data
m6w6 added a commit to m6w6/msgpack-php that referenced this pull request Feb 28, 2020
+ Improved performance + Upgraded bundled msgpack headers to 3.2.0 * Merged PR msgpack#101: Update README in order to match compatibile PHP version * Merged PR msgpack#125: fix ce->name is a zend_string * Merged PR msgpack#106: Update README * Merged PR msgpack#126: add mising tests in archive * Merged PR msgpack#135: Add fixes for issue msgpack#81 This also includes tests. * Merged PR msgpack#143: Fixed build with PHP-7.4 * Fixed issue msgpack#139: Segmentation fault when using cloned unpacker * Fixed issue msgpack#132: Segfault on session php7.3 * Fixed issue msgpack#107: $unpacker->execute() bug * Fixed issue msgpack#83: Arrays and negative index * Fixed issue msgpack#137: DateTime(Immutable) serialization doesn't work with php 7.4 RC1 * Fixed issue msgpack#105: MessagePackUnpacker() bug * Fixed issue msgpack#90: msgpack_unpack is super slow (30x times igbinary) on big data sets * Fixed issue msgpack#91: Private property in base class * Fixed issue msgpack#67: Integer overflow on a 64-bit system * Fixed issue msgpack#33: int64 and uint64 decode is not supported in 32-bit php * Fixed issue msgpack#119: uint64 numbers are cast to uint on Windows * Fixed issue msgpack#134: msgpack-php msgpack_serialize/msgpack_pack not handling properly large int * Fixed issue msgpack#81: Serialize optimization * Fixed issue msgpack#108: tests/041.phpt failure * Fixed issue msgpack#142: Recursion encoded as NULL * Fixed issue msgpack#138: Serializers comparison for session like data
m6w6 added a commit that referenced this pull request Feb 28, 2020
+ Improved performance + Upgraded bundled msgpack headers to 3.2.0 * Merged PR #101: Update README in order to match compatibile PHP version * Merged PR #125: fix ce->name is a zend_string * Merged PR #106: Update README * Merged PR #126: add mising tests in archive * Merged PR #135: Add fixes for issue #81 This also includes tests. * Merged PR #143: Fixed build with PHP-7.4 * Fixed issue #139: Segmentation fault when using cloned unpacker * Fixed issue #132: Segfault on session php7.3 * Fixed issue #107: $unpacker->execute() bug * Fixed issue #83: Arrays and negative index * Fixed issue #137: DateTime(Immutable) serialization doesn't work with php 7.4 RC1 * Fixed issue #105: MessagePackUnpacker() bug * Fixed issue #90: msgpack_unpack is super slow (30x times igbinary) on big data sets * Fixed issue #91: Private property in base class * Fixed issue #67: Integer overflow on a 64-bit system * Fixed issue #33: int64 and uint64 decode is not supported in 32-bit php * Fixed issue #119: uint64 numbers are cast to uint on Windows * Fixed issue #134: msgpack-php msgpack_serialize/msgpack_pack not handling properly large int * Fixed issue #81: Serialize optimization * Fixed issue #108: tests/041.phpt failure * Fixed issue #142: Recursion encoded as NULL * Fixed issue #138: Serializers comparison for session like data
m6w6 added a commit that referenced this pull request Aug 20, 2024
+ Improved performance + Upgraded bundled msgpack headers to 3.2.0 * Merged PR #101: Update README in order to match compatibile PHP version * Merged PR #125: fix ce->name is a zend_string * Merged PR #106: Update README * Merged PR #126: add mising tests in archive * Merged PR #135: Add fixes for issue #81 This also includes tests. * Merged PR #143: Fixed build with PHP-7.4 * Fixed issue #139: Segmentation fault when using cloned unpacker * Fixed issue #132: Segfault on session php7.3 * Fixed issue #107: $unpacker->execute() bug * Fixed issue #83: Arrays and negative index * Fixed issue #137: DateTime(Immutable) serialization doesn't work with php 7.4 RC1 * Fixed issue #105: MessagePackUnpacker() bug * Fixed issue #90: msgpack_unpack is super slow (30x times igbinary) on big data sets * Fixed issue #91: Private property in base class * Fixed issue #67: Integer overflow on a 64-bit system * Fixed issue #33: int64 and uint64 decode is not supported in 32-bit php * Fixed issue #119: uint64 numbers are cast to uint on Windows * Fixed issue #134: msgpack-php msgpack_serialize/msgpack_pack not handling properly large int * Fixed issue #81: Serialize optimization * Fixed issue #108: tests/041.phpt failure * Fixed issue #142: Recursion encoded as NULL * Fixed issue #138: Serializers comparison for session like data
m6w6 added a commit that referenced this pull request Aug 20, 2024
+ Improved performance + Upgraded bundled msgpack headers to 3.2.0 * Merged PR #101: Update README in order to match compatibile PHP version * Merged PR #125: fix ce->name is a zend_string * Merged PR #106: Update README * Merged PR #126: add mising tests in archive * Merged PR #135: Add fixes for issue #81 This also includes tests. * Merged PR #143: Fixed build with PHP-7.4 * Fixed issue #139: Segmentation fault when using cloned unpacker * Fixed issue #132: Segfault on session php7.3 * Fixed issue #107: $unpacker->execute() bug * Fixed issue #83: Arrays and negative index * Fixed issue #137: DateTime(Immutable) serialization doesn't work with php 7.4 RC1 * Fixed issue #105: MessagePackUnpacker() bug * Fixed issue #90: msgpack_unpack is super slow (30x times igbinary) on big data sets * Fixed issue #91: Private property in base class * Fixed issue #67: Integer overflow on a 64-bit system * Fixed issue #33: int64 and uint64 decode is not supported in 32-bit php * Fixed issue #119: uint64 numbers are cast to uint on Windows * Fixed issue #134: msgpack-php msgpack_serialize/msgpack_pack not handling properly large int * Fixed issue #81: Serialize optimization * Fixed issue #108: tests/041.phpt failure * Fixed issue #142: Recursion encoded as NULL * Fixed issue #138: Serializers comparison for session like data
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st part is for 7.3 (fcc.initialized removed)
2nd is for 7.0+ (7.3 allow to raise to -Wformat warning and thus detect this issue)