Skip to content

Conversation

@ibobo
Copy link
Contributor

@iboboibobo commented Jul 4, 2016

Hi, I added support to use Msgpack as a serializer for APCu. This was needed to me because IgBinary is very unstable under PHP 7 (gives a Segmentation Fault whenever you try to use it as a session or APCu serializer) and I want to switch to the newer runtime version.

In the coming days I will do some more testing. If some of you have any suggestion on how to improve the pull request, I will be happy to fix it.

PS. I see the CI build fails for test 029 since it doesn't have APCu installed. Maybe I could add support for APC as well and update .travis.yml to use it. Let me know!

Thanks!

@codecov-io
Copy link

codecov-io commented Jul 31, 2016

Codecov Report

Merging #93 into master will decrease coverage by -0.25%.

@@ Coverage Diff @@## master #93 +/- ## ========================================== - Coverage 87.19% 86.95% -0.25%  ========================================== Files 8 8 Lines 1234 1234 ========================================== - Hits 1076 1073 -3 - Misses 158 161 +3
Impacted FilesCoverage Δ
msgpack.c92% <ø> (ø)
msgpack_unpack.c85.49% <ø> (-0.91%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6472b9f...17bc8ca. Read the comment docs.

@andypost
Copy link
Contributor

TEST 30/123 [tests/029.phpt] ========DIFF======== 005- APCu Serializer Support => enabled ========DONE======== FAIL Msgpack module info [tests/029.phpt] 

It looks like apu is not loaded when tests run

@andypost
Copy link
Contributor

Other failed tests are not compatible with PHP 7 #109

@m6w6
Copy link
Collaborator

m6w6 commented Dec 18, 2019

Hi! Thanks for this submission.

Please rebase this PR, so we can have a closer look!

@andypost
Copy link
Contributor

#162 still looking for reviews

@m6w6m6w6 added this to the 2.1 milestone Jun 2, 2023
m6w6 added a commit that referenced this pull request Aug 20, 2024
@m6w6m6w6 closed this Aug 20, 2024
m6w6 added a commit that referenced this pull request Aug 20, 2024
m6w6 added a commit that referenced this pull request Aug 23, 2024
* Add support for PHP-8.1 Enums * merges #173 * fixes#171 * Add support for APCu * merges #162, #93 * Add OPT_ASSOC for roundtrip serialization of map. * merges #58
m6w6 added a commit that referenced this pull request Sep 25, 2024
* Add support for PHP-8.1 Enums * merges #173 * fixes#171 * Add support for APCu * merges #162, #93 * Add OPT_ASSOC for roundtrip serialization of map. * merges #58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ibobo@codecov-io@andypost@m6w6