Skip to content

Conversation

@ThomasWaldmann
Copy link
Contributor

@ThomasWaldmannThomasWaldmann commented Aug 31, 2023

also: replace flake8 by ruff.

@ThomasWaldmann
Copy link
ContributorAuthor

I converted the metadata from setup.cfg "as is" to pyproject.toml.
I also added some stuff that is currently commented out as a suggestion, these were not present in setup.cfg.

Maybe interesting for another PR: https://stackoverflow.com/questions/74608905/single-source-of-truth-for-python-project-version-in-presence-of-pyproject-toml

@ThomasWaldmann
Copy link
ContributorAuthor

Hmm, the black section targets py37 (which is not within the supported python versions) - shall that be py38?

@ThomasWaldmannThomasWaldmann marked this pull request as ready for review August 31, 2023 10:55
also: clean up some stuff it complained about.
@ThomasWaldmannThomasWaldmann mentioned this pull request Sep 4, 2023
@methanemethane changed the title move project metadata to pyproject.toml, fixes #540move project metadata to pyproject.tomlSep 5, 2023
@methanemethane linked an issue Sep 5, 2023 that may be closed by this pull request
2 tasks
@methanemethane removed a link to an issue Sep 5, 2023
2 tasks
@methanemethane merged commit 423c6df into msgpack:mainSep 5, 2023
@ThomasWaldmannThomasWaldmann deleted the metadata-pep621 branch September 5, 2023 10:51
@ThomasWaldmann
Copy link
ContributorAuthor

@methane Maybe you missed my comment about the suggestions / commented stuff in pyproject.toml - maybe just look through it and remove the comment chars to activate all suggestions you like to have.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ThomasWaldmann@methane