combined changes from simon-weber and kmbenitez; will fix #126#127
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…res and from kmbenitez to use subprocess instead of pip internals
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could have done this differently but this was easiest for me as I already had my own fork. I took the changes from @simon-weber to abstractly declare install_requires (which was in its own separate PR) and the changes from @kmbenitez to use subprocess instead of pip internals (which was not in a PR). The first is a harmless change that was being asked for; the second is a necessary change to fix a bug that prevents more than one package from being deployed (which has existed since 3.2.2 - ever since pip changed its internals, apparently).