Skip to content

Conversation

@bourgeoa
Copy link
Member

@bourgeoabourgeoa commented Jan 20, 2023

This implements the discovery and creation/modification of HTML data island : a script HTML block containing RDF data.
See #1714

@bourgeoabourgeoa self-assigned this Jan 20, 2023
@bourgeoabourgeoa linked an issue Jan 20, 2023 that may be closed by this pull request
@bourgeoabourgeoa changed the title GET/PATCH HTML data islandGET/PATCH for HTML data island in NSSJan 22, 2023
returnnext()
}catch(err){
if(err.message==='404'){
returnnext(error(404,'HTML do not contain data island'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
returnnext(error(404,'HTML do not contain data island'))
returnnext(error(404,'HTML does not contain any data islands'))

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plural in islands seems to allow multiples. Actually my PR only allows one.
Not sure that more than one could be expected. The id="data" cannot be used more than once in an html document.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be multiple islands in a single HTML doc, tho perhaps not (yet) in your environment. My error text is equivalent to saying, "I found no data island in this HTML," among other phrasings.

Another phrasing suggestion might be, HTML does not contain a data island.

@melvincarvalho
Copy link
Contributor

Thanks very much for looking at this. I am very interested in this work. Was it ever tried? If not, I could perhaps try running the branch, to see what it looks like.

@bourgeoa
Copy link
MemberAuthor

It has been implemented in SolidOS source-pane where you can test it.
Not in NSS. I don't remember why.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test RDF in a data island in the HTML

4 participants

@bourgeoa@melvincarvalho@TallTed