Skip to content

Conversation

@bourgeoa
Copy link
Member

No description provided.

@bourgeoabourgeoa requested a review from zg009March 15, 2024 09:54
@bourgeoabourgeoa linked an issue Mar 15, 2024 that may be closed by this pull request
Copy link
Contributor

@zg009zg009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me since you just changed the error code. I'm not sure if the build failing needs to be resolved or not.

@bourgeoabourgeoa requested a review from zg009March 15, 2024 21:31
@bourgeoabourgeoa self-assigned this Mar 15, 2024
@zg009
Copy link
Contributor

Alain did you need me to review this again, or test it locally?

@bourgeoa
Copy link
MemberAuthor

No I just wanted to see if you were an allowed reviewer.
I ran the tests locally. Only the NSS ones, not the test-suite (solid specification tests)
The test issue is irritating. Around the same location, not always exactly the same and only in CI.
Locally the same test-suite tests pass without any issue.

@bourgeoabourgeoa merged commit bd171fa into mainMar 16, 2024
@bourgeoabourgeoa deleted the fix/issue#1771 branch March 16, 2024 07:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Username leakage from account creation

3 participants

@bourgeoa@zg009