Skip to content

Set rejectUnauthorized on solid-test#546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmitrizagidulin merged 3 commits into from
Aug 16, 2017
Merged

Set rejectUnauthorized on solid-test #546

dmitrizagidulin merged 3 commits into from
Aug 16, 2017

Conversation

@RubenVerborgh
Copy link
Contributor

@RubenVerborghRubenVerborgh commented Aug 16, 2017

No description provided.

@RubenVerborgh
Copy link
ContributorAuthor

RubenVerborgh commented Aug 16, 2017

@dmitrizagidulin Another possibility is to rename the option into --no-reject-unauthorized.

@dmitrizagidulin
Copy link
Contributor

dmitrizagidulin commented Aug 16, 2017

Renaming it to --no-reject-unauthorized seems reasonable. (Denotes that rejecting is the normal state, and that not doing it is the exception.)

@RubenVerborghRubenVerborghforce-pushed the fix/solid-test-rejectunauthorized branch 2 times, most recently from 18fa2c7 to 98bd7d6CompareAugust 16, 2017 19:11
@RubenVerborgh
Copy link
ContributorAuthor

RubenVerborgh commented Aug 16, 2017

@dmitrizagidulin Thanks, updated.

@RubenVerborghRubenVerborghforce-pushed the fix/solid-test-rejectunauthorized branch from 98bd7d6 to 613766dCompareAugust 16, 2017 19:14
@RubenVerborgh
Copy link
ContributorAuthor

RubenVerborgh commented Aug 16, 2017

@dmitrizagidulin …and without Warp this time.

@dmitrizagidulin
Copy link
Contributor

dmitrizagidulin commented Aug 16, 2017

Hehe, thanks

dmitrizagidulin
dmitrizagidulin approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@dmitrizagidulindmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmitrizagidulindmitrizagidulin merged commit b3b755b into dz_oidcAug 16, 2017
@dmitrizagidulindmitrizagidulin deleted the fix/solid-test-rejectunauthorized branch August 16, 2017 21:23
@RubenVerborghRubenVerborgh mentioned this pull request Aug 17, 2017
Merged
RubenVerborgh added a commit that referenced this pull request Aug 17, 2017
@RubenVerborgh
Add CHANGELOG entry for solid-test (#530,#546).
15eaebb
RubenVerborgh added a commit that referenced this pull request Sep 3, 2017
@RubenVerborgh
Add CHANGELOG entry for solid-test (#530,#546).
f0d0a70
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dmitrizagidulindmitrizagidulindmitrizagidulin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmitrizagidulindmitrizagidulin

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RubenVerborgh@dmitrizagidulin