Expose WAC-Allow to browser clients#556
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
RubenVerborghforce-pushed the fix/wac-allow-cors branch from 03642c7 to 5746766Compare
dan-f approved these changes Aug 22, 2017
Contributor
dan-f left a comment
dan-f left a comment There was a problem hiding this comment.
Just a question regarding WAC semantics. 👍
| resource: '/user-rw-public-r', | ||
| headers: {'WAC-Allow': 'user="read write append",public="read"'} | ||
| headers: { | ||
| 'WAC-Allow': 'user="read write append",public="read"', |
ContributorAuthor
There was a problem hiding this comment.
Yes, the current ACL checker sets Append whenever it finds Write.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the proper CORS permissions on the header introduced in #550.