Update databrowser.html to latest mashlib#640
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
RubenVerborghforce-pushed the fix/databrowser-update branch 2 times, most recently from 88fdf53 to 9bcabbbCompare
RubenVerborghforce-pushed the fix/databrowser-update branch from 9bcabbb to fffd7e7Compare
ContributorAuthor
RubenVerborgh commented Feb 27, 2018
Problem (which also existed with the previous version): |
timbl approved these changes Mar 3, 2018
Contributor
timbl left a comment
timbl left a comment There was a problem hiding this comment.
Looks good to me. Sorry it took to long (where can I find a list of github things waiting for my review?)
Contributor
timbl commented Mar 3, 2018
Looks good to me and important. Maybe in future we make the databrowser.html file an export of dome sort from mashlib? |
ContributorAuthor
RubenVerborgh commented Mar 3, 2018
Right here: https://github.com/solid/node-solid-server/pulls/review-requested/timbl
Yes, and/or replace the JavaScript by a single line, such as Mashlib.init({pane: 'outliner',subject: location.href,element: 'outline'}) |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of the public mashlib at https://linkeddata.github.io/mashlib/dist/mashlib.min.js is no longer compatible with the old mashlib API. As such, databrowser.html has to change.
This PR is a combination of the current databrowser.html at timbl.com and https://github.com/linkeddata/mashlib/blob/c87ca0ac4c71177d29efd4a68ea105650401f0aa/dist/databrowser.html.