Add ResourceMapper class for URL/file mapping#643
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
RubenVerborghforce-pushed the feature/resourcemapper branch from d5c8d0a to c7a95b3CompareRubenVerborghforce-pushed the feature/resourcemapper branch from 087ddb8 to 37ad4f2Compare
melvincarvalho approved these changes Mar 9, 2018
Contributor
melvincarvalho left a comment
melvincarvalho left a comment There was a problem hiding this comment.
Looks good given there are tests and it doesnt touch other code
Only thing is that some more code was added after 'ready to review'
ContributorAuthor
RubenVerborgh commented Mar 9, 2018
@melvincarvalho Thanks and yeah, did an iterative review process with @timbl here 😄 |
RubenVerborghforce-pushed the feature/resourcemapper branch from 37ad4f2 to f4c885cCompare
2 tasks
This was referenced May 3, 2018
Closed
This was referenced Jul 19, 2018
This was referenced Nov 14, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.