Skip to content

Conversation

@RubenVerborgh
Copy link
Contributor

The server URI's protocol would be determined based on the protocol of the request only, which could be different if Solid is behind a reverse proxy.

The server URI's protocol would be determined based on the protocol of the request only, which could be different if Solid is behind a reverse proxy.
Copy link
Contributor

@dmitrizagidulindmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

RubenVerborgh added a commit that referenced this pull request Apr 21, 2018
This makes them have the same protocol, which can be different because of #651.
@timbltimbl self-assigned this Apr 21, 2018
Copy link
Contributor

@timbltimbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RubenVerborghRubenVerborgh merged commit 03428a6 into developApr 22, 2018
@RubenVerborghRubenVerborgh deleted the fix/baseuri-behind-proxy branch April 22, 2018 10:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@RubenVerborgh@dmitrizagidulin@timbl