Prevent double slashes in the "service" link header

[ninachaubal]

Resolves#634

[dmitrizagidulin]

Thanks @ninachaubal! :)

Could you by any chance add a unit test or something, to that function?

[RubenVerborgh]

@ninachaubal Thanks! However, interpolation is not the problem, but the extra slash is. No need to perform an actual resolve, since we know the first part will end in a slash and the second part is a constant without special path expressions. Let's add a test and then we can merge.

[ninachaubal]

Hey, sorry I couldn't get to this sooner.

I agree that we don't need to perform an actual resolve here, but I'm not certain we can assume that first part will end in a slash. As far as I can tell, the first part will end in a slash if req.path ends in a slash and express doesn't make any guarantees about that.

Would it be reasonable to edit utils.getFullUri() to guarantee an ending slash? Alternatively, we could use something like url-join to ensure there aren't multiple slashes without doing a resolve.

On the tests, what's the best place to put them? Should I add a new file under test/unit for options or is there an existing test suite you would like me to add these to?

[RubenVerborgh]

I'm not certain we can assume that first part will end in a slash.

Resolve is perfect then, thanks!

On the tests, what's the best place to put them?

Looks like test/integration/capability-discovery-test.js is the place to go.

[ninachaubal]

@RubenVerborgh, could you take another look at this PR?

[RubenVerborgh]

Thanks!