Group acl integration#719
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dmitrizagidulinforce-pushed the group-acl-integration branch from ddbed22 to ced16d4Compare
ContributorAuthor
dmitrizagidulin commented Jul 6, 2018
(Rebased on latest |
…erver into group-acl-integration
RubenVerborgh approved these changes Jul 12, 2018
| "rimraf": "^2.5.0", | ||
| "solid-namespace": "^0.1.0", | ||
| "solid-permissions": "^0.5.2", | ||
| "solid-permissions": "solid/solid-permissions#feature-group-acl", |
Contributor
There was a problem hiding this comment.
Should be updated to release version.
(Note: in the future, you can just put the next release version here, and use npm ln locally.)
| // assert.equal(response.statusCode, 201) | ||
| // done() | ||
| // }) | ||
| // }) |
| <#folks> | ||
| a vcard:Group; | ||
| vcard:hasUID <urn:uuid:8831CBAD-1111-2222-8563-F0F4787EG398:ABGroup> |
| // first try loading from local fs | ||
| return ldp.getGraph(uri, options.contentType) | ||
| // failing that, fetch remote graph | ||
| .catch(() => ldp.fetchGraph(uri, options)) |
Contributor
There was a problem hiding this comment.
We'll probably need better logic for this in the future.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for integration testing the Group ACL functionality in
permission-set