Skip to content

Fix infinite recursion when using GridLayout#356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a7ul merged 1 commit into from
Aug 16, 2021
Merged

Fix infinite recursion when using GridLayout #356

a7ul merged 1 commit into from
Aug 16, 2021

Conversation

@foxt
Copy link
Contributor

@foxtfoxt commented Aug 16, 2021•
edited
Loading

Maximum call stack size exceeded error happens when using GridLayout.

Fixes#348

@a7ul
Copy link
Collaborator

a7ul commented Aug 16, 2021

Thanks for the pr!
@all-contributors add @theLMGN for code

@a7ula7ul merged commit b478312 into nodegui:masterAug 16, 2021
@allcontributorsallcontributorsbot mentioned this pull request Aug 16, 2021
Merged
@allcontributors
Copy link
Contributor

allcontributorsbot commented Aug 16, 2021

@a7ul

I've put up a pull request to add @theLMGN! 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RangeError when using GridView or BoxView

2 participants

@foxt@a7ul