Fix Image.src on Windows when it is a local file#363
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`new URL("C:\path\filename.png")` is treated as a valid URL, which it is not. `phin` subsequently tries to fetch it, but `phin` and `centra` only supports http and https anyway. Therefore `isValidUrl` will check also the protocol.ContributorAuthor
NinZine commented Oct 14, 2021
Fixes #358 |
Collaborator
a7ul commented Oct 14, 2021
Thanks @NinZine |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new URL("C:\path\filename.png")is treated as a valid URL, which it is not.
phinsubsequently triesto fetch it, but
phinandcentraonly supports http and https anyway.Therefore
isValidUrlwill check also the protocol.