Add comment about string encoding.#32
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
2 tasks
Member
bnoordhuis commented Dec 12, 2016
Sounds sensible to me. ChakraCore, JavaScriptCore and Spidermonkey all seem to support it and at least in Spidermonkey it's the canonical (i.e. fast) representation. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
jasongin pushed a commit to jasongin/abi-stable-node that referenced this pull request Jan 26, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
JS VM Api
Description of change
In V8, strings are
utf16. Would it make sense to have anapi_get_string_utf16? Or is conversion toutf8a performance hit we don't mind?