jenkins: fix coverage gcovr patches#1145
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
targos commented Feb 23, 2018
LGTM if it works |
killagu added a commit to killagu/node that referenced this pull request Feb 23, 2018
1 task
Member
mhdawson commented Feb 26, 2018
I'll try to test this out later today. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Member
mhdawson commented Feb 28, 2018
Generated coverage successfully. @killagu many thanks for putting together the 2 PRs to fix this, landing |
mhdawson pushed a commit that referenced this pull request Feb 28, 2018
PR-URL: #1145 Ref: nodejs/node#18938 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: MichaëZasso <[email protected]>
Member
mhdawson commented Feb 28, 2018
Landed as f577cb8 |
ContributorAuthor
killagu commented Feb 28, 2018
🎉🎉🎉 |
mhdawson pushed a commit to nodejs/node that referenced this pull request Feb 28, 2018
PR-URL: #18958Fixes: #18938 Ref: nodejs/build#1145 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Mar 5, 2018
PR-URL: nodejs#18958Fixes: nodejs#18938 Ref: nodejs/build#1145 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18958Fixes: nodejs#18938 Ref: nodejs/build#1145 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#18938