Skip to content

chore: port changes from node core#178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 3 commits into from
Jan 27, 2025
Merged

chore: port changes from node core #178

aduh95 merged 3 commits into from
Jan 27, 2025

Conversation

@ovflowd
Copy link
Member

@ovflowdovflowd commented Jan 26, 2025•
edited
Loading

@ovflowdovflowd requested a review from a team as a code ownerJanuary 26, 2025 15:59
@aduh95
Copy link
Contributor

aduh95 commented Jan 26, 2025

Would it make sense to put me as author or co-author? FWIW you can cherry-pick the commits from the nodejs/node repo

@ovflowd
Copy link
MemberAuthor

ovflowd commented Jan 26, 2025

Would it make sense to put me as author or co-author? FWIW you can cherry-pick the commits from the nodejs/node repo

Not sure I can cherry pick given the paths are different and the source is also different (styles got prettied differently)

But feel free to checkout and then amend the commit with you as co-author on all of them!

@ovflowd
Copy link
MemberAuthor

ovflowd commented Jan 26, 2025

Would it make sense to put me as author or co-author? FWIW you can cherry-pick the commits from the nodejs/node repo

Not sure I can cherry pick given the paths are different and the source is also different (styles got prettied differently)

But feel free to checkout and then amend the commit with you as co-author on all of them!

Bump @aduh95 just so you don't forget ❤️

@aduh95aduh95force-pushed the chore/port-node-changes branch from 69ce469 to c7d9e51CompareJanuary 27, 2025 00:00
ovflowd
ovflowd commented Jan 27, 2025
View reviewed changes
@aduh95
doc: improve accessibility of expandable lists
1da598d
PR-URL: nodejs/node#56749 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
@aduh95
doc: add "Skip to content" button
a4ea425
PR-URL: nodejs/node#56750 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
@aduh95
doc: fix styles of the expandable TOC
cb66e80
PR-URL: nodejs/node#56755 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@aduh95aduh95force-pushed the chore/port-node-changes branch from c7d9e51 to cb66e80CompareJanuary 27, 2025 00:15
AugustinMauroy
AugustinMauroy approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@AugustinMauroyAugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank to both of you (Antoine and Claudio)

@aduh95aduh95 merged commit cb66e80 into mainJan 27, 2025
7 checks passed
@aduh95aduh95 deleted the chore/port-node-changes branch January 27, 2025 22:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flakey5flakey5flakey5 approved these changes

@AugustinMauroyAugustinMauroyAugustinMauroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ovflowd@aduh95@flakey5@AugustinMauroy