Automating docker-node part of the official Node Docker images release process

[Pehesi97]

Description

• Create GH Action
• Check official node builds for new versions
• If there is a new version, check for new musl builds
• If there is a new musl build, and not a security release
• Run update.sh according to the situation (-s if security release)
• If there's no new version, exit gracefully
• Create a new PR with the changes made by update.sh
• Create a new action that runs when CI is green for the recently created PR and automatically merge it

Motivation and Context

#1312

Testing Details

Example Output(if appropriate)

Types of changes

• Documentation
• Version change (Update, remove or add more Node.js versions)
• Variant change (Update, remove or add more variants, or versions of variants)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Others (non of above)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING.md document.
• All new and existing tests passed.

[SimenB]

@Pehesi97 just notice this, exciting! Feel free to ping if/when you're ready for feedback.

/cc @nodejs/docker

[SimenB]

I'll merge this later today (CET) unless anybody says otherwise - would like to see it handle the new v17 release

[SimenB]

I've enabled auto merge, maybe we can use that instead of polling and juliangruber/merge-pull-request-action? I.e. enable that for the PRs or something.

EDIT: right

I tried lots of approaches to make that auto-merge feature work (I won't share all the details unless you want me to) but ended up using a script that waits up to 5 minutes for the PR's CI to turn green.

I'd love to hear those reasons 🙂 I've now enabled the auto merge feature, and we already have branch protection rules, so I think all 3 conditions in the docs are ok: https://github.com/peter-evans/enable-pull-request-automerge#conditions

We also require a review, so we probably need the auto approve action as well

[Pehesi97]

Yeah, I think that will work.

My main issue when trying to make auto-merge work was that the check suite isn't static (we create it dynamically using GitHub Actions) and it wasn't enough to trigger the "Require status checks to pass before merging" rule. I didn't try requiring approvals for the auto-merge to work, and all the others were already satisfied by the time I opened a test PR.

About the auto-approve-action, I think https://github.com/hmarr/auto-approve-action will do the trick.

Do you want me to do the changes?

[SimenB]

If it works, I'd prefer to use auto merge over a manual poll, yes 🙂

[Pehesi97]

@SimenB actually, I don't think that will work.

For auto-approving the PR, we would need the checks to pass. That's kinda the point of polling the GitHub API.

[SimenB]

Fair enough. Merging will fail unless an approval is added though, so we need that part anyways

[SimenB]

all of these actions can run with the default token.

However, approval must happen with a different token as it's not allowed to approve your own PR

[SimenB]

@Pehesi97 see Pehesi97#27

(also, very sorry for all the back and forth 😬)

[Pehesi97]

It's OK. I understand.

[SimenB]

I'm not 100% the automerge will work, but as mentioned in Pehesi97#27 (comment), just getting the PR is a great first step.

Thank you so much for working on this @Pehesi97, and thanks for your patience!

[shaneog]

Should this have kicked off a new build/release process for this Node.js release from yesterday? Or should I open a PR for that?

[nschonni]

Looks like the Alpine builds still aren't available

[shaneog]

Just released: PR here