Try to find a comment to edit before creating#228
Uh oh!
There was an error while loading. Please reload this page.
Conversation
| constgetPRComments=`query getPRComments($owner: String!, $repo: String!, $number: Int!, $cursor: String){ | ||
| repository(owner: $owner, name: $repo){ | ||
| pullRequest(number: $number){ | ||
| comments(first: 20, after:$cursor){ |
There was a problem hiding this comment.
| comments(first: 20,after:$cursor){ | |
| comments(first: 100,after:$cursor){ |
I just put 20 to see if the recursive querying works.
| constnewBody=`${oldBody}\n${body}` | ||
| returngithubClient.issues.editComment({ owner, repo, id,body: newBody}) | ||
| } | ||
| returngithubClient.issues.createComment({ owner, repo, number, body }) |
There was a problem hiding this comment.
For sure like the looks of using GraphQL and promises 👍
| nodes{ | ||
| name | ||
| } | ||
| } |
There was a problem hiding this comment.
Planning to use these labels for something?
There was a problem hiding this comment.
If we want to recognize a bot-out label, for complete opt-out.
phillipj commented Mar 28, 2019
Leaning towards keeping these changes instead of what I suggested in #226, especially when it comes to talking to the GitHub API. The other difference from the mentioned PR, is tests. You got any plans for more tests? |
refack commented Mar 28, 2019
That's my current WIP... mocking the GQL calls. (H/T to @gr2m for https://github.com/octokit/graphql.js/#writing-tests) |
Uh oh!
There was an error while loading. Please reload this page.
gr2m commented Mar 28, 2019
Holler if you run into any blockers or have any questions about GitHub APIs / Octokit, happy to help |
phillipj commented Apr 3, 2019
phillipj commented May 2, 2019
@refack would you mind if I dived into getting a test in place, with the goal of getting this merged & deployed? |
phillipj commented May 5, 2019
@refack as I would really appreciate getting this landed soon, I took the freedom of rebasing with master to fix a PTAL |
phillipj commented Jun 5, 2019
cjihrig commented Jun 5, 2019
I'd still prefer if the bot limited its commenting when possible. |
phillipj commented Jun 10, 2019
Alrighty then, let's give this a test round to see how it behaves 🚀 Rebased and force push to fix conflict in |
phillipj commented Jun 10, 2019
This is now live in production. |
Reverting changes related to editing existing comments, going back to the previous behaviour of always creating new comments in PRs about CI / Jenkins runs. This is done primarily due to two things: * It has broken node-core-utils' ability to check if CI's have been run * There's not collaborator consensus about editing comments is actually better than creating new comments Future plans for bot PR comments going forward has to be discussed more thorougly and ensured it doesn't break other automation tools used by collaborators. Refs nodejs#228
Reverting changes related to editing existing comments, going back to the previous behaviour of always creating new comments in PRs about CI / Jenkins runs. This is done primarily due to two things: * It has broken node-core-utils' ability to check if CI's have been run * There's not collaborator consensus about editing comments is actually better than creating new comments Future plans for bot PR comments going forward has to be discussed more thoroughly and ensured it doesn't break other automation tools used by collaborators. Refs #228
4 participants
@octokit/graphql