src: fix JSError inspection#215
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
mmarchini commented Jul 16, 2018
Still need to add the metadata to V8 before landing this. |
mmarchini changed the title kisg pushed a commit to paul99/v8mips that referenced this pull request Jul 16, 2018
* JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475}
Member
joyeecheung commented Jul 16, 2018
Is there an estimate of the time the V8 patch will land in Node? |
ContributorAuthor
mmarchini commented Jul 17, 2018
Since the patch landed on V8 6.9, I'll open backport PRs to all relevant Node.js Release lines (v8.x and v10.x). |
mmarchini pushed a commit to mmarchini/node that referenced this pull request Jul 23, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693
mmarchini pushed a commit to nodejs/node that referenced this pull request Jul 25, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 PR-URL: #21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
ContributorAuthor
mmarchini commented Jul 25, 2018
Backport landed on core master: nodejs/node#21855 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
targos pushed a commit to targos/node that referenced this pull request Jul 25, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 PR-URL: nodejs#21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Jul 26, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 PR-URL: nodejs#21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jul 26, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 PR-URL: #21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Jul 26, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 PR-URL: nodejs#21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
mmarchini pushed a commit to mmarchini/node that referenced this pull request Aug 7, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 PR-URL: nodejs#21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Aug 7, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 Backport-PR-URL: #22177 PR-URL: #21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Aug 7, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 Backport-PR-URL: #22177 PR-URL: #21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
ContributorAuthor
mmarchini commented Aug 8, 2018
CI should be green (except for #209) after the next v8.x release. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
MylesBorins pushed a commit to nodejs/node that referenced this pull request Aug 9, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 Backport-PR-URL: #22177 PR-URL: #21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Aug 10, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 Backport-PR-URL: #21668 PR-URL: #21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Aug 16, 2018
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 Backport-PR-URL: #22177 PR-URL: #21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
added 2 commits September 11, 2018 09:44
This commit fixes JSError inspection for Node.js v7+. We still need to figure out a way to get the stack from the Error object though. Ref: nodejs#143
mmarchini pushed a commit that referenced this pull request Sep 11, 2018
This commit fixes JSError inspection for Node.js v7+. We still need to figure out a way to get the stack from the Error object though. Ref: #143 PR-URL: #215 Refs: #143 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
ContributorAuthor
mmarchini commented Sep 11, 2018
Landed in 816c46c |
hyj1991 pushed a commit to aliyun-node/llnode that referenced this pull request Sep 17, 2018
This commit fixes JSError inspection for Node.js v7+. We still need to figure out a way to get the stack from the Error object though. Ref: nodejs#143 PR-URL: nodejs#215 Refs: nodejs#143 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 Backport-PR-URL: nodejs/node#21668 PR-URL: nodejs/node#21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes JSError inspection for Node.js v7+. We still need to
figure out a way to get the stack from the Error object though.
Ref: #143