Skip to content

Conversation

@mildsunrise
Copy link
Contributor

Refs: nodejs/node#42461

We currently defer finalizer callbacks until the loop is idle.

Warn users that the weak reference on ObjectWrap isn't guaranteed to be valid just because the object hasn't been finalized (destructed) yet.

Refs: nodejs/node#42461 We currently defer finalizer callbacks until the loop is idle. Warn users that the weak reference on ObjectWraps isn't guaranteed to be valid just because the object hasn't been finalized (destructed) yet.
Copy link
Member

@NickNasoNickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawsonmhdawson merged commit 8c46a95 into nodejs:mainMar 31, 2022
@mildsunrisemildsunrise deleted the doc-napi-finalize branch March 31, 2022 22:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mildsunrise@NickNaso@mhdawson