src,test,build: allow NAPI_VERSION env var and templatize AttachData …#1402
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…callback PR-URL: nodejs#1399 Reviewed-By: Chengzhong Wu <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]>
ContributorAuthor
gabrielschulhof commented Nov 6, 2023
@legendecas can you please approve this PR? It's identical to #1399. I tried to merge that one, but for some reason it didn't end up on |
ContributorAuthor
@legendecas alternatively, is there a way to fast-forward main to https://github.com/nodejs/node-addon-api/commits/c52e764bb285d347348e5401e963976fbc6acba0? |
Member
legendecas commented Nov 6, 2023
I temporarily disabled branch protection rules and fast-forwarded the main branch to c52e764. I believe it would be simpler to use GitHub UI to land PRs since node-core-utils is not available in this repo. |
ContributorAuthor
gabrielschulhof commented Nov 6, 2023
@legendecas thanks a lot! I'll merge PRs via the UI going forward. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…callback
PR-URL: #1399
Reviewed-By: Chengzhong Wu <@legendecas>