build: split up cpplint to avoid long cmd lines

[kfarnung]

• Added a separate cpplint run for chakrashim
• Added setlocal to the start of the script to prevent environment
  variables from leaking out

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

build

[kfarnung]

@refack Do you know of any reasons why we can't take the setlocal upstream? That should make the script cleaner since the environment variables get reset when the script exits.

[refack]

vcvarsall.bat 😞
But I already promised nodejs/node#14115 (comment) to work on nodejs/node#12310

[refack]

Ohh and nodejs/node#13969

[kfarnung]

Hmm, I'm not seeing any issue with the addition. Everything spawned by the batch script inherits the full set of environment variables, it's just that once the script ends the variables are restored to their prior state.

Are there any cases where we run vcbuild.bat and depend on the leaked variables on subsequent runs?

/cc @joaocgreis

[kfarnung]

Kicked off a CI run: https://ci.nodejs.org/job/chakracore-test-pull-request/101/

[refack]

So until about a week ago DISTTYPEDIR was explicitly leaked.
And having vcvarsall.bat setup the dev environment is very handy.
So the CI will probably pass, but it's still semver-major (since vcbuild.bat if used downstream by a bunch of vendors)

[kfarnung]

Ok, makes sense, I'll just remove that for now. I was seeing some weird behavior where it seemed like some variables were being leaked and appended to until they were too long to be used. I'll just keep an eye out for a repro and try to debug.

[refack]

I was seeing some weird behavior where it seemed like some variables were being leaked and appended to until they were too long to be used. I'll just keep an eye out for a repro and try to debug.

It's a known bug of VS2015's vcvarsall.bat, I accidently removed a guard around it in nodejs/node@780acc2

[refack]

Can you upstream this

[kfarnung]

Thanks @refack!

Upstream PR: nodejs/node#14116

[refack]

@kfarnung the "line too long" issue fix landed nodejs/node#13765

[kfarnung]

@refack Thanks!