Skip to content

Conversation

@mmarchini
Copy link
Contributor

skipChecks will allow skipping certain checks. Useful to skip "commit
after last approval" on commit queue.

Ref: nodejs/node#34770

skipChecks will allow skipping certain checks. Useful to skip "commit after last approval" on commit queue. Ref: nodejs/node#34770
@mmarchini
Copy link
ContributorAuthor

I'm not 100% sure we're going to use this, but I guess it doesn't hurt to have it either.

@codecov
Copy link

codecovbot commented Aug 15, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.70%. Comparing base (4b32ebc) to head (ad6349c).
⚠️ Report is 401 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #475 +/- ## ========================================== + Coverage 82.56% 82.70% +0.13%  ========================================== Files 34 34 Lines 1658 1671 +13 ========================================== + Hits 1369 1382 +13  Misses 289 289 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

default: false,
type: 'boolean'
},
skipChecks: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this option to documentation as well, perhaps with an accompanying example :)

@codebytere
Copy link
Member

@mmarchini could you rebase this?

@github-actions
Copy link
Contributor

This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mmarchini@codebytere@aduh95