feat: add --lite option for git-node land (makes it usable with repos other than nodejs/node)#546
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to use
git-node landin repositories other thannodejs/node. This is helpful for producing Node-style commitfooters, and enforcing some Node PR/commit conventions.
Context: Looking into whether
git-node landcan be used for landing stuff at thenode-gyprepo. With this change, the answer would be "yes."See: nodejs/node-gyp#2286
cc @rvagg thoughts? (I like that
git-node landtakes some of the work out of using Node-style commit message prefixes, and maintaining commit message footers such asReviewed-By:andPR-URL:, but dropping all that and just usingrelease-pleaseand "conventional commit"-style commit messages would be even easier.)Note to
node-core-utilsmaintainers: Ifnode-gypmaintainers aren't interested in this--liteflag feature, then I don't think there is a real-world user for it. In that case, with no real-world users, I wouldn't recommend merging this. Basically, I can only see this being useful ifnode-gypmaintainers want it (or someone pops up in the comments here to say they want it).