Skip to content

Conversation

@VoltrexKeyva
Copy link
Member

  • Replace the inquirer dependency with @inquirer/prompts as the former is now legacy.
  • Update the log-symbols dependency and the sinon development dependency to their new major
    versions.
  • Update all other dependencies & development dependencies to their latest versions.

- Replace the `inquirer` dependency with `@inquirer/prompts` as the former is now legacy. - Update the `log-symbols` dependency and the `sinon` development dependency to their new major versions. - Update all other dependencies & development dependencies to their latest versions.
@VoltrexKeyva
Copy link
MemberAuthor

VoltrexKeyva commented Sep 27, 2024

Please note that I have not tested the inquirer changes because to see the prompts I would need to use commands that may have real effects on the main repository, it'd be appreciated if someone can test them.

Side note: I still have not updated the ESLint and related development dependencies because eslint-plugin-import still does not support ESLint v9.

There's also this strange error in the tests:

[DEBUG] AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: assert.ok(body._validated) at Object.<anonymous> (file:///home/runner/work/node-core-utils/node-core-utils/test/unit/ci_start.test.js:144:22) at Object.invoke (file:///home/runner/work/node-core-utils/node-core-utils/node_modules/sinon/pkg/sinon-esm.js:586:32) at Object.functionStub (file:///home/runner/work/node-core-utils/node-core-utils/node_modules/sinon/pkg/sinon-esm.js:3924:43) at Function.invoke (file:///home/runner/work/node-core-utils/node-core-utils/node_modules/sinon/pkg/sinon-esm.js:2551:47) at Object.functionStub [as fetch] (file:///home/runner/work/node-core-utils/node-core-utils/node_modules/sinon/pkg/sinon-esm.js:2856:26) at RunPRJob.start (file:///home/runner/work/node-core-utils/node-core-utils/lib/ci/run_ci.js:90:43) at async TestContext.<anonymous> (file:///home/runner/work/node-core-utils/node-core-utils/test/unit/ci_start.test.js:1[52](https://github.com/nodejs/node-core-utils/actions/runs/11074428387/job/30773193587?pr=860#step:14:53):28) at async Test.run (node:internal/test_runner/test:790:9) at async Suite.processPendingSubtests (node:internal/test_runner/test:517:7){ generatedMessage: true, code: 'ERR_ASSERTION', actual: undefined, expected: true, operator: '=='}

Copy link
Member

@targostargos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the inquirer changes with a couple commands.

@VoltrexKeyva
Copy link
MemberAuthor

I tested the inquirer changes with a couple commands.

Thanks a lot, any idea about the error in the tests I mentioned?

@targos
Copy link
Member

I haven't looked at it

@aduh95
Copy link
Contributor

any idea about the error in the tests I mentioned?

CI is green though 🤔 Is this an error you see locally, or was it fixed since your comment?

@VoltrexKeyva
Copy link
MemberAuthor

any idea about the error in the tests I mentioned?

CI is green though 🤔 Is this an error you see locally, or was it fixed since your comment?

I don't know how the CI is green despite that error, if you check the logs of the "Run tests" step of every check in the CI run, the same error is present, here is an example.

@VoltrexKeyva
Copy link
MemberAuthor

@aduh95 ping.

@aduh95aduh95 mentioned this pull request Nov 2, 2024
@aduh95aduh95 merged commit f43c721 into nodejs:mainNov 6, 2024
@VoltrexKeyvaVoltrexKeyva deleted the update-deps branch November 6, 2024 08:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@VoltrexKeyva@targos@aduh95