Skip to content

Conversation

@aduh95
Copy link
Contributor

I cannot see why we would prefer having several git push commands. However, I see a number of reasons to have only one, at the very end of the --promote sequence:

  • it makes it less likely a release would go half through, e.g. if the releaser has to abandon the release before the git push for whatever reason.
  • for folks watching the repo, the delay between "the proposal branch gets merged" and "the release tag is out" can be frustrating.
  • it removes the need for a --continue (cc @RafaelGSS); with this PR, you either have pushed and the only remaining command is tools/release.sh, or you haven't pushed and can start over.

Copy link
Member

@RafaelGSSRafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95
Copy link
ContributorAuthor

It's probably wiser to wait for a release proposal PR to be open so this can be tested, I reckon I might be missing a .trim() call somewhere

@RafaelGSS
Copy link
Member

Right, so I'm going to land #868 without this change

@aduh95
Copy link
ContributorAuthor

Just tested it with nodejs/node#55879, a .trim() call was indeed needed

@aduh95aduh95 merged commit 82527ad into nodejs:mainNov 19, 2024
11 checks passed
@aduh95aduh95 deleted the git-push-once branch November 19, 2024 16:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@aduh95@RafaelGSS