This repository was archived by the owner on Apr 22, 2023. It is now read-only.
build: fix VS2015 ICU/Intl breakage <56 (v0.12)#25804
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
srl295 commented Aug 3, 2015
srl295 changed the title srl295 changed the title 
probably fixesnodejs#25792 Also, adds general mechanism for floating patches on top of ICU. The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. backport from: nodejs/node#2283 * includes responses to comments in from io.js version * also apply patch to ICU 55 (if/when that is merged)
MemberAuthor
srl295 commented Aug 4, 2015
As of 3e46d6d this is parallel to the io.js side |
MemberAuthor
srl295 commented Aug 13, 2015
@joaocgreis do you want to take this as part of your work? |
Member
joaocgreis commented Aug 13, 2015
Member
joaocgreis commented Aug 19, 2015
@srl295 I think it would be good to reorganize the commit message, and then I can take care of landing this. There is no official guide for commit messages for ports that I know of, so I've been adapting the one specific for v8. I would amend the commit message to something like: Feel free to change/add anything in my suggestion. If you're ok with it as it is, I can also take care of this and land, let me know. |
MemberAuthor
srl295 commented Aug 24, 2015
@joaocgreis the message looks good to me. |
srl295 added a commit that referenced this pull request Aug 24, 2015
This change is a backport of nodejs/node@4c06515. Original commit message: The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. Also, adds general mechanism for floating patches on top of ICU. Fixes: nodejs/node#2279 PR-URL: nodejs/node#2283 Reviewed-By: João Reis <[email protected]> Fixes: #25792 PR-URL: #25804 Reviewed-By: João Reis <[email protected]>
Member
joaocgreis commented Aug 24, 2015
CI: https://jenkins-iojs.nodesource.com/job/node-test-commit/281/ Landed in 4f24563. Thank you! |
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
This change is a backport of nodejs/node@4c06515. Original commit message: The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. Also, adds general mechanism for floating patches on top of ICU. Fixes: nodejs/node#2279 PR-URL: nodejs/node#2283 Reviewed-By: João Reis <[email protected]> Fixes: nodejs#25792 PR-URL: nodejs#25804 Reviewed-By: João Reis <[email protected]>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebased to v0.12
probably fixes#25792
Also, adds general mechanism for floating patches on top of ICU.
The particular ufile.c is from
http://bugs.icu-project.org/trac/changeset/37704
and should be OK for ICU 54 and 55.
backport from: nodejs/node#2283