http2: use more descriptive names

PR-URL: #17328Fixes: #15303 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sebastiaan Deckers <[email protected]>

Author: jasnell

lib/internal/http2/core.js

@@ -582,15 +582,15 @@ function doShutdown(options){
 functionsubmitShutdown(options){
 consttype=this[kType];
 debug(`Http2Session ${sessionName(type)}: submitting shutdown request`);
-constfn=doShutdown.bind(this,options);
+constshutdownFn=doShutdown.bind(this,options);
 if(type===NGHTTP2_SESSION_SERVER&&options.graceful===true){
 // first send a shutdown notice
 this[kHandle].shutdownNotice();
 // then, on flip of the event loop, do the actual shutdown
-setImmediate(fn);
+setImmediate(shutdownFn);
 return;
 }
-fn();
+shutdownFn();
 }
 
 functionfinishSessionDestroy(socket){
@@ -877,12 +877,12 @@ class Http2Session extends EventEmitter{
 debug(`Http2Session ${sessionName(this[kType])}: sending settings`);
 
 state.pendingAck++;
-constfn=submitSettings.bind(this,settings);
+constsettingsFn=submitSettings.bind(this,settings);
 if(state.connecting){
-this.once('connect',fn);
+this.once('connect',settingsFn);
 return;
 }
-fn();
+settingsFn();
 }
 
 // Destroy the Http2Session
@@ -968,14 +968,14 @@ class Http2Session extends EventEmitter{
 this.on('shutdown',callback);
 }
 
-constfn=submitShutdown.bind(this,options);
+constshutdownFn=submitShutdown.bind(this,options);
 if(state.connecting){
-this.once('connect',fn);
+this.once('connect',shutdownFn);
 return;
 }
 
 debug(`Http2Session ${sessionName(type)}: sending shutdown`);
-fn();
+shutdownFn();
 }
 
 _onTimeout(){
@@ -1379,12 +1379,12 @@ class Http2Stream extends Duplex{
 if(code<0||code>kMaxInt)
 thrownewerrors.RangeError('ERR_OUT_OF_RANGE','code');
 
-constfn=submitRstStream.bind(this,code);
+constrstStreamFn=submitRstStream.bind(this,code);
 if(this[kID]===undefined){
-this.once('ready',fn);
+this.once('ready',rstStreamFn);
 return;
 }
-fn();
+rstStreamFn();
 }
 
 rstWithNoError(){
@@ -1415,12 +1415,12 @@ class Http2Stream extends Duplex{
 options=Object.assign({},options);
 validatePriorityOptions(options);
 
-constfn=submitPriority.bind(this,options);
+constpriorityFn=submitPriority.bind(this,options);
 if(this[kID]===undefined){
-this.once('ready',fn);
+this.once('ready',priorityFn);
 return;
 }
-fn();
+priorityFn();
 }
 
 // Called by this.destroy().